Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode opens multiple tabs with the same url #5930

Closed
philolypse opened this issue Nov 22, 2021 · 5 comments
Closed

VSCode opens multiple tabs with the same url #5930

philolypse opened this issue Nov 22, 2021 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@philolypse
Copy link

  • Open few windows connected to the remote
  • Open and run project that will automatically open browser tab with project url (like serve)
  • VSCode will open as many tabs as we have windows opened in vscode
@alexr00
Copy link
Member

alexr00 commented Nov 23, 2021

project that will automatically open browser tab

@philolypse what do you expect to cause the browser tabs to open?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Nov 23, 2021
@philolypse
Copy link
Author

My bad, i've provided serve js as an example and i don't see an option to automatically open link in browser there. Sorry.

Let's use xdg-open command as an example.

what do you expect to cause the browser tabs to open?

I don't really know how passing the "open link in a browser" event from remote to client process is done, but i suspect that all connected vscode instances are listening for the same thing (which is okay, they should "listen") and that is causing the problem - having multiple tabs opened (in my case) instead of just one.

Another way to test it:

  • open multiple windows of vscode
  • connect all of them to the same remote
  • run e.g. xdg-open http://localhost in remote terminal
  • the same amount of browser tabs will be opened as we have connected instances in vscode

I've tested it on:
Client: macOS 12.0.1
Remote: Ubuntu 21.10
VSCode: 1.62.3

@alexr00
Copy link
Member

alexr00 commented Nov 29, 2021

Thanks, I can reproduce this.

@Tyriar do you have any idea why this could happen? I'm seeing RemoteTerminalBackend execute _remoteCLI.openExternal.

@Tyriar
Copy link
Member

Tyriar commented Nov 29, 2021

Probably related to this one microsoft/vscode#121926

@alexr00 alexr00 assigned Tyriar and unassigned alexr00 Nov 30, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@github-actions github-actions bot closed this as completed Dec 7, 2021
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants