Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote-SSH: Kill server ask to login first #6228

Closed
aeschli opened this issue Jan 25, 2022 · 6 comments
Closed

Remote-SSH: Kill server ask to login first #6228

aeschli opened this issue Jan 25, 2022 · 6 comments
Assignees
@tanhakabir
Labels
ssh Issue in vscode-remote SSH

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 25, 2022

Testing #6220

Windows
Remote-WSL v0.71.2021121615 (pre-release)
Version: 1.64.0-insider (user setup)
Commit: f93c69659de1a1466bd15e0f1c9f790e73be9208
Date: 2022-01-25T08:42:41.055Z
OS: Windows_NT x64 10.0.19044

  • open a remote SSH window and open a folder
  • run the Kill VS Code Server on Host command
  • I'm prompted to decide to which host to connect. Then I'm prompted to enter the password
  • The window reopens. A notification tells me that the server has been killed.
@aeschli
Copy link
Contributor Author

aeschli commented Jan 25, 2022

Recording 2022-01-25 at 17 03 34

@aeschli
Copy link
Contributor Author

aeschli commented Jan 25, 2022

Also see #6227

@tanhakabir
Copy link

I believe potentially the same root cause.

@aeschli in your settings do you have remote.SSH.useLocalServer: true? We have this issue on Windows for appropriately setting useLocalServer: #6147 (comment)

@tanhakabir tanhakabir added the ssh Issue in vscode-remote SSH label Jan 25, 2022
@sbatten
Copy link
Member

sbatten commented Jan 25, 2022

I'm seeing the same and verified that useLocalServer is true.

@tanhakabir
Copy link

Sorry just noticed the @aeschli used Kill VS Code Server on Host. This expected. I expect Kill Current VS Code Server not not prompt for password

@aeschli
Copy link
Contributor Author

aeschli commented Jan 25, 2022

The Remote-SSH version is now v0.71.2022012519

I didn't see Kill Current VS Code Server before.

In deed Kill Current VS Code Server is doing it correctly (no prompt)

@aeschli aeschli closed this as completed Jan 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tanhakabir tanhakabir

Labels
ssh Issue in vscode-remote SSH
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aeschli @sbatten @tanhakabir