Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Allow for default value in ${localEnv:...} and ${containerEnv:...} #7100

Closed
2 tasks done
chrmarti opened this issue Aug 22, 2022 · 1 comment
Closed
2 tasks done
Labels
containers Issue in vscode-remote containers testplan-item
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Aug 22, 2022

Refs: devcontainers/spec#63

Complexity: 2

Create Issue


Use the latest Remote-Containers pre-release (currently 0.248.0) or Dev Containers CLI (currently 0.12.1) for testing.

A devcontainer.json's property values can reference environment variables locally and inside the container. Test that the updated syntax supports having a default value that is used when the environment variable is not set: ${localEnv:ENV_VAR:default_value} and ${containerEnv:ENV_VAR:default_value}

@chrmarti chrmarti added this to the August 2022 milestone Aug 22, 2022
@chrmarti chrmarti added the containers Issue in vscode-remote containers label Aug 22, 2022
@ghost ghost assigned lszomoru and amunger Aug 23, 2022
@lszomoru
Copy link
Member

Works as advertised 🎉

@lszomoru lszomoru assigned aeschli and unassigned lszomoru and amunger Aug 24, 2022
@aeschli aeschli removed their assignment Aug 25, 2022
@mjbvz mjbvz closed this as completed Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants