Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to rebuild on reload if devcontainer.json or associated Dockerfile/compose files have been updated #758

Closed
Chuxel opened this issue Jun 21, 2019 · 1 comment
Assignees
Labels
containers Issue in vscode-remote containers plan-item A plan item

Comments

@Chuxel
Copy link
Member

Chuxel commented Jun 21, 2019

A few people I have talked to have mentioned that they find themselves forgetting to rebuild their container(s) after modifying devcontainer.json or the related Dockerfile or docker-compose.yml. This is particularly easy to forget if you are making small edits. I admit I have done this myself.

While it could be annoying to prompt to rebuild on every edit or save, it might make sense to ask if the container should be rebuilt when container is reopened since this is a less frequent operation.

//cc: @chrimarti - Does this make sense to you as well?

@Chuxel Chuxel added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Jun 21, 2019
@dilin-MS
Copy link

Our Azure IoT Device Workbench is integrating containerization mechanism leveraging the vscode remote extension.
In our scenario, we will scaffold project files which include a .devcontainer directory containing Dockerfile and devcontainer.json file.

.devcontainer
├── Dockerfile
└── devcontainer.json

The user can develop their application in the container built from the Dockerfile. We also want to allow user to modify the Dockerfile adding their customized configurations. So we are in need of this prompt on reload feature to rebuild docker image when Dockerfile is modified. It's okay to prompt rebuild when reload project.

Looking forward to the feature.

@chrmarti chrmarti self-assigned this Sep 23, 2019
@chrmarti chrmarti added this to the September 2019 milestone Sep 23, 2019
@chrmarti chrmarti added plan-item A plan item and removed feature-request Request for new features or functionality labels Sep 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers plan-item A plan item
Projects
None yet
Development

No branches or pull requests

3 participants