-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git repositories inside dev containers on git >= 2.35.2 are always reported as unsafe #7628
Comments
Previously suggested in #6810 (comment) |
The specific command that fixes it is:
One could add that to the One could add that to the There's no clear winner workaround here. |
Documentation suggests that this should only trigger when the folder's owner is different from the current user. I wonder if we might reintroduce the vulnerability this is fixing if we automatically add the folder as a |
There's an argument somewhere around this suggestion being specific to dev containers and their inherent strange permission conventions. |
Could you run I would like to better understand how this was set up. (Detailed steps would be best.) |
More detailed steps:
🐛 Once the workspace opens and the git extension activates, it will show the error |
This is a real problem for me, is
the workaround? |
Also having this issue, and I believe it causes the .gitconfig not to copy into my devcontainer. I'm running WSL2 Ubuntu 20.04 |
I'm adding a fix to the single container case (Docker Compose case needs more investigation) where the repository root folder is added as a safe directory in the container if the current user in the container is not the same as the owner of the repository root folder and on the local machine the current user and the owner of the repository root folder are the same. This is available in Dev Containers 0.274.0-pre-release. Will open a new issue to investigate adding this for Docker Compose setups too. |
Brilliant, thank you |
@chrmarti would you please be able to link a pull request link about this change? I still have the issue using pre-release version
|
Steps to Reproduce:
Miniconda (Python 3)
on a folder with a git repo, it should pick up git version >= 2.35.2🐛 The git extension kicks in since git can't trust that repository due to the new git vulnerability fix.
IMO Remote Containers should automatically add the following to the copied
.gitconfig
:The text was updated successfully, but these errors were encountered: