Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Dev Containers contributions to the remote indicator #8018

Closed
8 of 10 tasks
joyceerhl opened this issue Feb 9, 2023 · 3 comments
Closed
8 of 10 tasks

Streamline Dev Containers contributions to the remote indicator #8018

joyceerhl opened this issue Feb 9, 2023 · 3 comments
Assignees
Labels
containers Issue in vscode-remote containers on-testplan plan-item A plan item
Milestone

Comments

@joyceerhl
Copy link

joyceerhl commented Feb 9, 2023

Ref #8016

Remote indicator cleanup

Local empty window

  • Show only Create Dev Container..., Attach to Running Container..., Clone Repository in Container Volume

Local folder

  • Show only Create Dev Container..., Attach to Running Container..., Add Dev Container Configuration Files..., Reopen Folder in Container

Dev container

  • Show only Create Dev Container..., Attach to Running Container..., Configure Container Features..., Reopen Folder Locally

Codespaces

  • Show only Create Dev Container..., Attach to Running Container..., Clone Repository in Container Volume

Remote Repositories

  • Show only Create Dev Container..., Attach to Running Container..., Continue Working in Dev Container... (via contribEditSession extension point)

WSL without folder

  • Show only Create Dev Container..., Attach to Running Container..., Clone Repository in Container Volume

WSL with folder

  • Show only Create Dev Container..., Attach to Running Container..., Add Dev Container Configuration Files..., Reopen Folder in Container

Tunnels

  • Show only Create Dev Container..., Attach to Running Container..., Clone Repository in Container Volume

SSH without folder

  • Show only Create Dev Container..., Attach to Running Container..., Clone Repository in Container Volume

SSH with folder

  • Show only Create Dev Container..., Attach to Running Container..., Add Dev Container Configuration Files..., Reopen Folder in Container

Additional cleanup

These are commands which we propose to remove from the remote indicator for now and surface in the command palette as well as potentially as quickpick buttons on the remote indicator itself.

  • Rename Getting Started... command to Get Started
  • Rename settings command to Dev Containers: Settings to be consistent and more concise
  • Rename command to Dev Containers: Help to be consistent and more concise
  • Rename command to Dev Containers: Report Issue... to be consistent and more concise
  • Contextually hide Dev Containers: Show Container Log unless a user is in a dev container; it just points to Terminal otherwise
  • Rename command Dev Containers Developer: Show All Logs... to Dev Containers: Show All Logs...
@drnielsen
Copy link

drnielsen commented Mar 6, 2023

I do a lot of devcontainer setup for my team and with this new change I am unsure how to rebuild the container. "Reopen folder locally..." followed by a "Reopen in container..." tends to use the cached version. It seems as if it's no longer possible to force rebuild a container and is a major UI miss with this change.

@joyceerhl
Copy link
Author

@drnielsen You should still be able to access Rebuild Container Without Cache from the command palette:
image

@drnielsen
Copy link

But why isn't this also in the menu by default? It seems like a highly relevant command while within a container.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers on-testplan plan-item A plan item
Projects
None yet
Development

No branches or pull requests

3 participants