Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto forwarded ports should be restored #8638

Closed
Tracked by #9044
alexr00 opened this issue Jun 26, 2023 · 1 comment · Fixed by microsoft/vscode#190442
Closed
Tracked by #9044

Auto forwarded ports should be restored #8638

alexr00 opened this issue Jun 26, 2023 · 1 comment · Fixed by microsoft/vscode#190442
Assignees
@alexr00
Labels
feature-request Request for new features or functionality on-testplan remote-explorer
Milestone
August 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 26, 2023 •
edited
Loading

At the time that remote.restoreForwardedPorts was added, we didn't have terminal reconnection. Now, restoration of auto forwarded ports needs to be revisited. This is complicated though by the source of the port:

  • If we're running the proc file system watcher and we can see that the process is still running, then we should definitely restore the port.
  • If the user has turned off the proc file system watcher then we should restore autoforwarded ports if we can also see that terminals have been reconnected.
@alexr00 alexr00 added feature-request Request for new features or functionality remote-explorer labels Jun 26, 2023
@alexr00 alexr00 added this to the July 2023 milestone Jun 26, 2023
@alexr00 alexr00 self-assigned this Jun 26, 2023
@alexr00 alexr00 modified the milestones: July 2023, August 2023 Jul 24, 2023
@kieferrm kieferrm mentioned this issue Aug 6, 2023
Closed
10 tasks
@alexr00 alexr00 mentioned this issue Aug 14, 2023
Merged
@alexr00
Copy link
Member Author

alexr00 commented Aug 14, 2023

Fixed by microsoft/vscode#190442

@alexr00 alexr00 mentioned this issue Aug 28, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality on-testplan remote-explorer
Projects
None yet
Milestone
August 2023
Development

Successfully merging a pull request may close this issue.

Restore autoforwarded ports microsoft/vscode
1 participant
@alexr00