Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Remove node-pty dependency from @devcontainers/cli #8748

Closed
3 tasks done
chrmarti opened this issue Jul 24, 2023 · 0 comments
Closed
3 tasks done

Test: Remove node-pty dependency from @devcontainers/cli #8748

chrmarti opened this issue Jul 24, 2023 · 0 comments
Labels
containers Issue in vscode-remote containers testplan-item
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Jul 24, 2023

Refs: #8698

Complexity: 2

Create Issue


  • Install @devcontainers/cli (note that it does not compile any native module): npm i -g @devcontainers/cli
  • Verify its subprocesses still use terminal escape sequences for rendering, e.g., docker build should show progress bars when building an image:
git clone https://github.com/microsoft/vscode-remote-try-node.git
cd vscode-remote-try-node
devcontainer build --workspace-folder .
@chrmarti chrmarti added containers Issue in vscode-remote containers testplan-item labels Jul 24, 2023
@chrmarti chrmarti added this to the July 2023 milestone Jul 24, 2023
@ghost ghost assigned gregvanl, hediet and dbaeumer Jul 25, 2023
@hediet hediet removed their assignment Jul 25, 2023
@gregvanl gregvanl removed their assignment Jul 25, 2023
@andreamah andreamah assigned Tyriar and unassigned dbaeumer Jul 25, 2023
@Tyriar Tyriar removed their assignment Jul 25, 2023
@Tyriar Tyriar closed this as completed Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants