Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code mounts not using cached consistency, Yarn extremely slow #879

Closed
miketamis opened this issue Jul 2, 2019 · 6 comments
Closed
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality

Comments

@miketamis
Copy link

When running yarn install inside the default node (LTS) container, it takes a long time to run.

[4/4] Building fresh packages...
success Saved lockfile.
Done in 625.55s.

Using macOS Mojave

Using Docker Desktop
Version 2.0.0.3 (31259)
Engine: 18.09.2

@sandorfr
Copy link

sandorfr commented Jul 2, 2019

I noticed that too, using cached consistency helped, not sure it resolved everything though

@egamma
Copy link
Member

egamma commented Jul 6, 2019

@Chuxel this would be a good addition to the tips and tricks section. The other way to speed this up is to create a volume and then do development inside the volume.

@Chuxel
Copy link
Member

Chuxel commented Jul 6, 2019

@egamma The is one of the reasons we added workspaceMount. Unfortunately it is waiting on #442 for a full fix since you need to use an absolute path. I also wonder if we shouldn't use cached for the default mount.

@Chuxel
Copy link
Member

Chuxel commented Jul 8, 2019

@egamma I forgot to mention that the cached consistency link above is from our docs... I could add something into tips and tricks that references it, but I think we should consider these +1s for #442 as well along with considering using cached by default.

@sandorfr
Copy link

sandorfr commented Jul 8, 2019

@egamma I forgot to mention that the cached consistency link above is from our docs... I could add something into tips and tricks that references it, but I think we should consider these +1s for #442 as well along with considering using cached by default.

yes I guess making it the default would save you from a lot of requests from people not reading the docs. Also as soon as a project is large enough it really the only viable option. At the moment it makes using docker compose pretty mandatory.

I would fix #442 with high priority though, docker might improve options on various operating system (maybe a tmpfs option will one day surface on windows, just guessing). You don't want people to be unable to harness future docker improvements by locking things done too much.

@Chuxel Chuxel changed the title Yarn extremely slow Source code mounts not using cached consistency, Yarn extremely slow Jul 9, 2019
@Chuxel Chuxel added feature-request Request for new features or functionality containers Issue in vscode-remote containers labels Jul 12, 2019
@Chuxel
Copy link
Member

Chuxel commented Jul 8, 2020

The specifics of this issue was actually resolved a while ago. There's the ability to pick the mount consistency as a property along with tips for using volume mounts to speed things up or using Open Repo in Container which uses a volume. Thanks!

@Chuxel Chuxel closed this as completed Jul 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants