Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test runner uses x64 on macOS ARM #122

Closed
bpasero opened this issue Jan 11, 2022 · 4 comments
Closed

Test runner uses x64 on macOS ARM #122

bpasero opened this issue Jan 11, 2022 · 4 comments
Assignees
Labels
important Issue identified as high-priority

Comments

@bpasero
Copy link
Member

bpasero commented Jan 11, 2022

I was wondering why test execution was so slow on my M1 MacBookPro and then noticed how this module missed to adopt support for our macOS ARM/Universal builds. I think this should be addressed as soon as possible.

Slightly related, we have Linux/Windows ARM builds as well, so the same could apply there?

@bpasero bpasero added the important Issue identified as high-priority label Jan 11, 2022
@connor4312
Copy link
Member

connor4312 commented Jan 11, 2022

I've added logic for this for OS X and Windows, however I do not have ARM devices to confirm on. Please verify this on @vscode/test-electron@2.0.3 🙂

@bpasero
Copy link
Member Author

bpasero commented Jan 12, 2022

@connor4312 thanks for the prompt fix, I verified this on macOS just now.

But what worries me is that our Yo generator pins the @vscode/test-electron dependency to a very old version: ^1.6.2.

@aeschli can you update the generator?

@aeschli
Copy link

aeschli commented Jan 12, 2022

@bpasero Pushed generator-code@1.6.6

@bpasero
Copy link
Member Author

bpasero commented Jan 12, 2022

Thanks 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants