Update to Electron 9

[deepak1556]

This plan item is to cover the work of updating to Electron 9.

Current Status:

• Update merged to master as version 9.1.0
• Insiders testing this week

[tduyduc]

Please note that this Electron update will update Chrome to version 79 or above. Chrome with versions from 79 is known to cause problems with some input methods for Linux.
There are bug reports about this matter here, here, and here, and none of them have been resolved yet.

[deepak1556]

We have found electron 8 has quite a few regression wrt chromium devtools and with vscode also disabling LayoutNG, this is causing some unknown renderer freezes or layout artifacts in electron 8. Both of these issues are fixes in Electron 9 which bumps chromium version to 83. We are exploring to update to this version in July iteration.

[PF4Public]

Why was "chore: update to electron 9-x-y" reverted recently?
Is it not coming soon?

[nrayburn-tech]

@PF4Public Some more information here, #103060 (comment).

[deepak1556]

We are moving forward with Electron 9 for stable this milestone.

[ghiscoding]

It seems that the push to latest version of Electron adds problem with Cypress, I'm getting the following error with VSCode Insiders (currently 1.50.0) since the last 1-2 versions of Insiders when trying to open Cypress from the VSCode terminal on Win10

electron: -max-http-header-size=1048576 is not allowed in NODE_OPTIONS

This works totally fine with VSCode Stable.

There's this Cypress issue that was opened but later closed by the user because it was suggested to start Cypress from a regular Windows terminal to start Cypress, while that works from a regular terminal, I would rather start it from VSCode since I have npm script shortcuts to start it from there.