Reloading/restoring workbench with open webview throws exception #100783

deepak1556 · 2020-06-22T20:02:13Z

VSCode Version: 1.47.0-insider 269f0fd
OS Version: macOS 10.15.5

Steps to Reproduce:

code-insiders
open markdown file and preview it
Command palette > Reload Window
Empty window with following exception

or

Open extension preview page
Reload Window
Same exception

  ERR Cannot read property 'onDidChange' of undefined: TypeError: Cannot read property 'onDidChange' of undefined
    at e.get onDidChange [as onDidChange] (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6261:668)
    at new f (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:584:327)
    at v._deserializeNode (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:333)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:191
    at Array.map (<anonymous>)
    at v._deserializeNode (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:172)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:191
    at Array.map (<anonymous>)
    at v._deserializeNode (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:172)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:191
    at Array.map (<anonymous>)
    at v._deserializeNode (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:172)
    at v._deserialize (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:77)
    at Function.deserialize (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:594:11)
    at Function.deserialize (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:603:550)
    at O.createWorkbenchLayout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6322:726)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6399:218
    at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1647:465)
    at O.startup (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6398:758)
    at q.open (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7478:911)
workbench.desktop.main.js:1666   ERR Cannot read property 'state' of undefined: TypeError: Cannot read property 'state' of undefined
    at e.saveState (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6266:461)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2998:628
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at e.flush (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2836:356)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6400:319
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:91:482
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:92:235
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:91:336
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:91:482
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:419:274
    at E.onResponse (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:419:882)
    at E.onBuffer (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:419:718)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:417:870
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at EventEmitter.n (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:93:143)
    at EventEmitter.emit (events.js:210:5)
    at Object.onMessage (electron/js2c/renderer_init.js:3465:16)

ERR Cannot read property 'state' of undefined: TypeError: Cannot read property 'state' of undefined
    at e.saveState (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6266:461)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2998:628
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at e.flush (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2836:356)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2836:277

workbench.desktop.main.js:4253 Extension host terminated unexpectedly. Code:  null  Signal:  SIGINT

ERR Cannot read property 'state' of undefined: TypeError: Cannot read property 'state' of undefined
    at e.saveState (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6266:461)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2998:628
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at e.close (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2836:544)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:7479:464
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6400:191
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:95:801)
    at e.handleWillShutdown (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4476:777)
    at EventEmitter.<anonymous> (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:4476:317)
    at EventEmitter.emit (events.js:210:5)
    at Object.onMessage (electron/js2c/renderer_init.js:3465:16)

Does this issue occur when all extensions are disabled?: Yes

The text was updated successfully, but these errors were encountered:

rebornix · 2020-06-22T21:38:34Z

It was introduced by 60d2192 , which registers EditorPart twice and ends up with registering EditorPart in layout service twice (the latter overrides the former one).

vscode/src/vs/workbench/browser/parts/editor/editorPart.ts

Lines 1144 to 1145 in 9d6054c

    
           registerSingleton(IEditorGroupsService, EditorPart); 
        
           registerSingleton(IEditorDropService, EditorPart);

rebornix · 2020-06-22T21:43:12Z

For anyone who is blocked by the empty workbench, CMD/Ctrl+Shift+N can still open a new window.

vjocw · 2020-06-23T18:29:02Z

For anyone who is blocked by the empty workbench, CMD/Ctrl+Shift+N can still open a new window.

@rebornix

I'm on my Mac OS X. Using CMD/Ctrl+Shift+N, I was able to get a new window open. However, I get the spinning wheel and I'm not able to interact with the window at all. Seems like I'm stuck in an infinite loop or similar. Any other suggestions?

I'm blocked right now from debugging an issue in our plugin.

deepak1556 added bug Issue identified by VS Code Team member as probable bug electron-8-update markdown Markdown support issues webview Webview issues and removed markdown Markdown support issues labels Jun 22, 2020

deepak1556 assigned mjbvz Jun 22, 2020

mjbvz assigned rebornix and sbatten Jun 22, 2020

rebornix assigned deepak1556 and bpasero and unassigned rebornix, sbatten, mjbvz and deepak1556 Jun 22, 2020

rebornix added this to the June 2020 milestone Jun 22, 2020

rebornix added important Issue identified as high-priority and removed electron-8-update webview Webview issues labels Jun 22, 2020

rebornix mentioned this issue Jun 22, 2020

Reloading the window does not retain the revealed position of the cell #99349

Closed

mjbvz mentioned this issue Jun 22, 2020

Markdown preview fails to load on any project #97503

Closed

deepak1556 mentioned this issue Jun 23, 2020

Workbench stays empty after reload with devtools open #100740

Closed

bpasero closed this as completed in d5c5c02 Jun 23, 2020

mjbvz added the verified Verification succeeded label Jul 2, 2020

github-actions bot locked and limited conversation to collaborators Aug 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reloading/restoring workbench with open webview throws exception #100783

Reloading/restoring workbench with open webview throws exception #100783

deepak1556 commented Jun 22, 2020 •

edited

Loading

rebornix commented Jun 22, 2020

rebornix commented Jun 22, 2020

vjocw commented Jun 23, 2020 •

edited

Loading

Reloading/restoring workbench with open webview throws exception #100783

Reloading/restoring workbench with open webview throws exception #100783

Comments

deepak1556 commented Jun 22, 2020 • edited Loading

rebornix commented Jun 22, 2020

rebornix commented Jun 22, 2020

vjocw commented Jun 23, 2020 • edited Loading

deepak1556 commented Jun 22, 2020 •

edited

Loading

vjocw commented Jun 23, 2020 •

edited

Loading