Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote: workspace color theme setting does not override default on startup #101893

Closed
rhomel opened this issue Jul 8, 2020 · 4 comments · Fixed by #109966
Closed

Remote: workspace color theme setting does not override default on startup #101893

rhomel opened this issue Jul 8, 2020 · 4 comments · Fixed by #109966
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues verified Verification succeeded
Milestone

Comments

@rhomel
Copy link

rhomel commented Jul 8, 2020

  • VSCode Version: 1.45, 1.46
  • OS Version: MacOS 10.14.6

Steps to Reproduce:

  1. Open a remote SSH folder.
  2. Add a custom workbench color theme to the workspace .vscode/settings.json:
{
    "workbench.colorTheme": "Quiet Light"
}
  1. Close VSCode and restart.

After Vscode starts up and opens the remote ssh folder, the workspace theme will not override the default setting.

Does this issue occur when all extensions are disabled?: N/A

This bug does not apply to local folders.

I was not sure where to file this bug since Vscode 1.44.2 works as expected.

@bpasero bpasero added the remote Remote system operations issues label Jul 8, 2020
@roblourens
Copy link
Member

I can repro this.

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jul 8, 2020
@sandy081 sandy081 removed their assignment Jul 17, 2020
@bcxpro
Copy link

bcxpro commented Jul 24, 2020

I have this issue since 1.46, 1.45 works ok for me.
There is an issue about this in vscode remote. microsoft/vscode-remote-release#3190

@roblourens roblourens removed their assignment Jul 25, 2020
@anthonyalayo
Copy link

+1 and thanks for filing, I was struggling with this issue and then I found this ticket. I'm facing this when using WSL.

@aeschli aeschli changed the title Remote SSH workspace color theme setting does not override default on startup Remote: workspace color theme setting does not override default on startup Nov 4, 2020
@bcxpro
Copy link

bcxpro commented Nov 6, 2020

Works in today's insider!

Version: 1.52.0-insider (user setup)
Commit: 24b28f57be22fe3029cb17a1dd72d8d9c2d6468b
Date: 2020-11-06T05:43:01.017Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042

@aeschli aeschli added this to the November 2020 milestone Nov 6, 2020
@roblourens roblourens added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders remote Remote system operations issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@roblourens @bpasero @rhomel @aeschli @sandy081 @anthonyalayo @bcxpro and others