Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Still Attaching Node Debugger with Run Without Debugging in 1.47.3 #103515

Closed
RyanLamanskyInsite opened this issue Jul 28, 2020 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)

Comments

@RyanLamanskyInsite
Copy link

  • VSCode Version: 1.47.3
  • OS Version: Windows 10 Professional 10.0.18363.959

Steps to Reproduce:

  1. Configure launch.json with a target of "node" and a JS file.
  2. Run without debugging

Expected:
1.46 and older behavior where it sends Node console output to the Debug tab but otherwise doesn't attach to the process in any way.

Actual:

A variant of #102057 where Node operates in an attached debugger mode with severe performance loss and this console output:

C:\Program Files\nodejs\node.exe c:\ISC\FrontEnd\startDevelopment.js
Debugger listening on ws://127.0.0.1:7607/ef0be773-49f8-4d75-8462-cf04a603d401
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.

I was monitoring the linked issue with the hope that it would resolve this, but the problem remains in 1.47.3.

Does this issue occur when all extensions are disabled?: Yes

@weinand weinand assigned connor4312 and unassigned weinand Jul 28, 2020
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 28, 2020
@connor4312
Copy link
Member

This comment explains what's happening: #102057 (comment)

In our tests there is little to no performance impact -- the 'debugger' domain isn't enabled, and by far the greatest runtime impact in debugging comes from enabling async stack trace tracking, which requires V8 to do extra bookkeeping. Let's continue the disucssion on the linked issue if you have more feedback to give. Thanks!

/duplicate

@makingglitches
Copy link

one thing that does not make sense is debugging was working throughout and there was no recent update to node js before the issue began.

@makingglitches
Copy link

didnt work.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants
@weinand @connor4312 @RyanLamanskyInsite @makingglitches and others