Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot close pane with cmd+w when tabs are disabled. #10357

Closed
cleversprocket opened this issue Aug 9, 2016 · 3 comments
Closed

Cannot close pane with cmd+w when tabs are disabled. #10357

cleversprocket opened this issue Aug 9, 2016 · 3 comments
Assignees
Labels
info-needed Issue requires more information from poster
Milestone

Comments

@cleversprocket
Copy link

  • VSCode Version: 1.4.0
  • OS Version: OSX 10.10.5

Steps to Reproduce:

  1. Disable Tabs by setting the rule "workbench.editor.showTabs": false in User settings settings.json
  2. Select a file to edit with cmd+p.
  3. Repeat step 2 with several different files.
  4. Open a new editor pane with cmd+2.
  5. Use step 2 in the new pane to open a file for editing.
  6. Repeat step 3 in the new pane.
  7. Attempt to close the new pane with cmd+w.

Expected Results:
The pane closes using cmd+w.

Actual Results:
cmd+w just closes the the file but the pane (or possibly the editor group?) remains open.

Notes:
This behavior started happening after Tabs was introduced. I've tried workbench.action.closeAllEditors and workbench.action.closeEditorsInGroup and the pane still will not close.

@bpasero
Copy link
Member

bpasero commented Aug 9, 2016

See #6605

@bpasero bpasero closed this as completed Aug 9, 2016
@cleversprocket
Copy link
Author

@bpasero I mentioned in the Notes section of the bug that using workbench.action.closeEditorsInGroup does not work.

@bpasero
Copy link
Member

bpasero commented Aug 12, 2016

@cleversprocket can you demo this in a video? or screenshots?

@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 12, 2016
@bpasero bpasero added this to the Backlog milestone Aug 12, 2016
@bpasero bpasero self-assigned this Aug 12, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants