Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test unified undo/redo/copy/paste/find actions in Notebook #103860

Closed
2 tasks done
rebornix opened this issue Aug 3, 2020 · 2 comments
Closed
2 tasks done

Test unified undo/redo/copy/paste/find actions in Notebook #103860

rebornix opened this issue Aug 3, 2020 · 2 comments

Comments

@rebornix
Copy link
Member

rebornix commented Aug 3, 2020

re #102441, #103861

Complexity: 3

Create Issue


Previously we create dedicated commands/actions for undo/redo/copy/paste/find/replace in Notebook. This iteration, we merged them into the editor commands, so users can use the keybindings they are familiar with and also run these commands through Menu.

Install GitHub Issue Notebook and test

  • Undo/Redo/Find/Replace through Keybindings or Menu. The behavior should be consistent no matter if the focus is in an embed Monaco editor in notebook, or on the notebook cell container.
  • Copy/Cut/Paste through Keybindings or Menu.
  • Copy in notebook:
    • Select some text in cell editor and then copy
    • Run a query, select some text in the ouputs and then copy
    • Switch the output mime type to text/markdown, select some text and then copy
    • Make sure in all three scenarios, the right text is copied into the clipboard
@rebornix
Copy link
Member Author

rebornix commented Aug 4, 2020

Undo/Redo was hijacked by webview actions in today's Insiders, fixed by e64364f and should be good from tomorrow Insiders.

@bamurtaugh
Copy link
Member

@rebornix I see Erich opened an issue about Undo/Redo. Closing issue for now, but if you'd like us to re-test after tomorrow's Insiders, please just let me know, and I'd be happy to re-open and test again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants