Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Pure Notebook Output Renderer #103885

Closed
2 tasks done
connor4312 opened this issue Aug 3, 2020 · 3 comments
Closed
2 tasks done

Test: Pure Notebook Output Renderer #103885

connor4312 opened this issue Aug 3, 2020 · 3 comments

Comments

@connor4312
Copy link
Member

connor4312 commented Aug 3, 2020

Refs: #102644

Complexity: 3

Create Issue


This month we introduced the concept of a "pure" renderer which is solely a webview/iframe-side bundle using the i/o from the renderer API.

  • Make sure "webview.experimental.useIframes": true is set to be able to test debugging
  • You can take one of two paths running this test plan:
    • If you own an existing impure notebook output renderer, convert it to the new API!
    • Otherwise, you can use the Yeoman generator which already has been updated to the new API: Test: yeoman generator for notebook #101319
      • Ensure the test provider is good, as well as code without the test provider (you can generate a renderer for the mime type x-application/github-issues that will render output from Joh's github issue notebooks)
      • Test that you can debug the client side code, that it hot reloads as you change it, and is sane overall.
@sbatten
Copy link
Member

sbatten commented Aug 5, 2020

@connor4312 after quite some time, I was able to figure out how to port my kusto extension into the new model. I very much like the code now, but let's chat tomorrow to talk about this since its hard for me to file issues as opposed to share my experience.

@sbatten sbatten removed their assignment Aug 5, 2020
@roblourens
Copy link
Member

Maybe @rebornix or I can join for that too?

@devinvalenciano
Copy link
Contributor

I was able to complete the steps in the test item above, to the best of my knowledge. Everything was functional, but one recommendation - the user could benefit from more documentation/guidance, especially in the generated README.md. The README doesn't explain how to use the test provider, how to understand each component of the renderer, where to begin customizing, etc... Unless you have a firm understanding of notebook architecture and mime types going in (which may be the only intended audience), it's going to be a challenge to get up to speed.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2020
@devinvalenciano devinvalenciano removed their assignment Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants