Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add indicator for the selected sort option #103941

Closed
lszomoru opened this issue Aug 4, 2020 · 6 comments
Closed

Add indicator for the selected sort option #103941

lszomoru opened this issue Aug 4, 2020 · 6 comments
Assignees
@sandy081
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2020

Comments

@lszomoru
Copy link
Member

lszomoru commented Aug 4, 2020

Testing #103615

Add a "tick mark" to indicate the selected sort option:

image
@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality labels Aug 4, 2020
@sandy081 sandy081 added this to the Backlog milestone Aug 4, 2020
@sandy081 sandy081 modified the milestones: Backlog, November 2020 Nov 9, 2020
@sandy081 sandy081 added the polish Cleanup and polish issue label Nov 9, 2020
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Nov 9, 2020
@jrieken jrieken added the verification-steps-needed Steps to verify are needed for verification label Dec 1, 2020
@jrieken
Copy link
Member

jrieken commented Dec 1, 2020

Screenshot 2020-12-01 at 12 34 47

That's all I see

@lszomoru
Copy link
Member Author

lszomoru commented Dec 1, 2020

@jrieken, it looks like the Views item is not present in the context menu when you search (expected @sandy081). If you clear the search field, you should see something similar in the context menu depending on the view that you have open:
image

@jrieken
Copy link
Member

jrieken commented Dec 1, 2020

I see the view thing but no "sort by" menu

@lszomoru
Copy link
Member Author

lszomoru commented Dec 1, 2020

sorry, my bad. it looks like indeed you need to run a search (ex: foo), then in the filter context menu there is an option to sort the search results. If you pick any of the options, the next time you open the context menu, you should see a tick that indicates the current sorting option:
image

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2020 •
edited
Loading

To verify:

  • Search for extensions in Marketplace by typing some text or use the predefined filters in the filter menu
  • Choose sort options from Sort by sub menu
  • Make sure that check mark is shown for the sort option that is used.

@sandy081 sandy081 removed the verification-steps-needed Steps to verify are needed for verification label Dec 1, 2020
@jrieken jrieken added the verified Verification succeeded label Dec 1, 2020
@jrieken
Copy link
Member

jrieken commented Dec 1, 2020

wow - it took me very long to find that menu

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
4 participants
@jrieken @lszomoru @sandy081 and others