Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom border of collapsed cell looks messy #104115

Closed
connor4312 opened this issue Aug 5, 2020 · 9 comments
Closed

Bottom border of collapsed cell looks messy #104115

connor4312 opened this issue Aug 5, 2020 · 9 comments
Assignees
Labels
*as-designed Described behavior is as designed notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues

Comments

@connor4312
Copy link
Member

connor4312 commented Aug 5, 2020

Testing #103887

The extra border here looks rather messy:

image

If we want to indicate there's folded content, maybe a light or dashed border aligned with the vertical centerline of the folded icon would look better?

@roblourens roblourens added notebook ux User experience issues under-discussion Issue is under discussion for relevance, priority, approach labels Aug 5, 2020
@rebornix
Copy link
Member

rebornix commented Aug 6, 2020

IMHO the bottom border for the collapsed outputs is not intuitive. I'm wondering if we can show a gray italic text "collapsed outputs" cc @misolori ?

@miguelsolorio
Copy link
Contributor

We could either add a ... in place:

Or add text:

I think I like the simpler ... approach and we can show a title tooltip when you hover over it

@roblourens
Copy link
Member

If we have a ... do we need the other expand codicon button? A ... button is literally just Jupyter's solution. Not opposed to it though.

@miguelsolorio
Copy link
Contributor

I would still keep our expand icon on the side, it’s more intuitive. The ... by itself is but vague. We also show the ... on folded regions in the editor And show the folded chevron on the side, so it aligns there.

@connor4312
Copy link
Member Author

connor4312 commented Aug 6, 2020

To me having the folded icon beside the ... icon feels weird. We basically have two icons that do and mean the same thing. I prefer the text version.

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Aug 6, 2020

@connor4312 but isn't that the same behavior in editor though?

image

We could move the ... to the middle of the cell so that it's an easier place for users to reach it if their mouse is on the opposite side of the screen?

@connor4312
Copy link
Member Author

Yea, but in the editor the context is different -- the gutter shows me my blocks (which just happens to be collapsed in this instance) while the editor shows me the content, which it indicates is collapsed.

... to the middle I think would look nicer. Particularly if we decide to make the whole bar clickable. This is similar to what the Azure portal does extensively

@miguelsolorio
Copy link
Contributor

Oh I definitely like that. One thing we'd need to work around is how it looks when it's centered because of our add new cell buttons:

image

@miguelsolorio
Copy link
Contributor

Collapsed cell has been updated:

CleanShot 2021-10-04 at 16 03 57@2x

@miguelsolorio miguelsolorio added the *as-designed Described behavior is as designed label Oct 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed notebook under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants