Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploration builds for apple silicon #104780

Closed
3 tasks done
deepak1556 opened this issue Aug 17, 2020 · 8 comments
Closed
3 tasks done

Exploration builds for apple silicon #104780

deepak1556 opened this issue Aug 17, 2020 · 8 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Aug 17, 2020

  • Update electron-11.x.y to v11.x.y
  • Publish build from ci
  • selfhost
@deepak1556
Copy link
Collaborator Author

This is now complete, electron-11.x.y branch creates exploration build for apple silicon.

@deepak1556
Copy link
Collaborator Author

Build that can run on DTK, please do file any issues that you may encounter

https://az764295.vo.msecnd.net/exploration/02c157e4258b4fc59515cad3194cda3f17eaa505/VSCode-darwin-exploration-arm64.zip

@tarasis
Copy link

tarasis commented Sep 11, 2020

Build that can run on DTK, please do file any issues that you may encounter

https://az764295.vo.msecnd.net/exploration/02c157e4258b4fc59515cad3194cda3f17eaa505/VSCode-darwin-exploration-arm64.zip

This is working for me on DTK. However after a bit it says there is an update, if you let it update then you get the “The window has crashed” error.

I assume updates will only appear here for now? (I’m disabling updates for the moment)

Edit: should bugs for this build be posted in this thread, or reported in main issues? (Opening DEV Tools crashes window, at least one extensions crash the extensions host (Bracket Pair Colorizer 2)

@deepak1556
Copy link
Collaborator Author

I assume updates will only appear here for now? (I’m disabling updates for the moment)

Yeah update system is still being worked on, will create a tracking issue for it.

should bugs for this build be posted in this thread

please create separate issues on the repo issue tracker. Thanks!

@pearcy
Copy link

pearcy commented Sep 12, 2020

Thank you deepak.

Working on DTK after I disabled the update.

@deepak1556
Copy link
Collaborator Author

Please use the following exploration build for apple silicon https://az764295.vo.msecnd.net/exploration/3cd7aea778b5886abc7acb0a8c1871d6f4bec6da/VSCode-darwin-arm64.zip , the previous version had an issue of pointing to incorrect update url. This new version should support automatic updates.

@rknall
Copy link

rknall commented Oct 16, 2020

Thanks for the update! Makes my life easier on the DTK by a mile. Any idea, when this will be part of the inside builds or even the regular ones?

@deepak1556
Copy link
Collaborator Author

the runtime bits for apple silicon are only available with Electron 11 which is still under beta release, so insiders won't be available until we adopt stable electron 11 which will be sometime in November.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

5 participants