-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delay to autosave #1055
Comments
There is a delay. I think what you are looking for is a less aggressive auto save, i.e., only on focus lost? |
Also related with: #353 |
@egamma yes, but what i mean is more like a save when idle, where the idle period is configurable. For example, autosave is triggered 10 seconds after I stop typing. I currently have auto save turned off, but I miss not having to worry about saving. @b12k save on focus would also work. A combination of both would be best :D |
@b12k found an interesting line of code: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/common/options.ts#L43
|
I am making progress on this feature request. I would like to avoid showing the dirty indication in the workbench at all cost because imho that is distracting. However this means, if you have configured auto save delay to be 10 seconds, the file will not be saved after that time without indication to the user. Any feedback on this is appreciated. |
@bpasero I don't know if any indication is needed. This setting isn't something most people are going to change, I think. Those who do make the change should be aware that there is a delay. If some sort of indication is really needed, perhaps something along the lines of number of dirty files? It would be similar to how the git icon has the number of modified files. The number of modified files sets a precedent. So, its not as if it would get any more distracting for anyone who thinks the dirty dots are.. uh.. dirty. |
I just find it interesting that other editors seem to keep all dirty indicators but save after some condition. That is not really a benefit to me, I really like that I also do not have to see any dirty indicators whatsoever because the application takes care of it. |
The delay is now configurable from the new |
@bpasero thanks! this will be in the January release? |
@tonyeung yes! |
I have a watch on my source files and while autosaving is great, every change triggers the rebuild process which is pretty crazy. Is it possible to have autosave wait till i stop typing(pause > configurable time) like search box debouncing.
The text was updated successfully, but these errors were encountered: