Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabCompletionController causes severe perf hit #10586

Closed
alexdima opened this issue Aug 16, 2016 · 2 comments
Closed

TabCompletionController causes severe perf hit #10586

alexdima opened this issue Aug 16, 2016 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority verified Verification succeeded
Milestone
August 2016

Comments

@alexdima
Copy link
Member

fyi @jrieken

  • Open attached file
  • Go to last line
  • click around

image

result - Copy.zip

getNonWhitespacePrefix-CPU-20160816T164203.cpuprofile.txt
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Aug 16, 2016
@alexdima alexdima added this to the August 2016 milestone Aug 16, 2016
@alexdima alexdima self-assigned this Aug 16, 2016
@jrieken
Copy link
Member

jrieken commented Aug 16, 2016

Coool. Would it make sense to push that down to the model?

@alexdima
Copy link
Member Author

I'd wait for one more consumer besides snippets before doing that

@joaomoreno joaomoreno added the verified Verification succeeded label Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @alexdima