Notebook: support line numbers and actions to toggle it

[rebornix]

We may want to support users to customize their line numbers and allow them to toggle line numbers with shortcuts.

[claudiaregio]

Question:

Would it look like this? (Numbering per cell)
Cell 1: 1 2 3
Cell 2: 1 2 3

Or like this? (Numbering for all code regardless of cell)
Cell 1: 1 2 3
Cell 2: 4 5 6

Would there be a way for users to pick which way they'd like to see it or is that what is meant by "support users to customize their line numbers"?

[DonJayamanne]

I'd prefer we as extension authors could provide defaults as well.
If running the second cell & there are errors in the cell, then Jupyter returns line numbers in the error message, however the line numbers start from 1 for the cell that was executed.

I.e. in the case of Jupyter, we don't need line numbers in subsequent cells to continue from previous cells (at least not for our Python extension).

[joyceerhl]

microsoft/vscode-jupyter#4810 is a related request to display the line and column number ticker in the status bar.

[rebornix]

In Jupyter, users can press L to toggle the line numbers for active cell, or Shift+L to toggle line numbers for all cells (and this config is also persisted).

[claudiaregio]

@rebornix is this supposed to work today? Does Jupyter need to do anything to enable it? I tried this out in my notebook and it doesnt work :(

[Syndorik]

@claudiaregio as far as VScode insider is concerned, I don't think it works. I can't activate/deactivate the line number per celll either

[rebornix]

We didn't have this yet. The note above is for me to capture what Jupyter does now.

[claudiaregio]

@rebornix ah ok this makes much more sense now, thanks

[rebornix]

Fixed via 804c1fc .