Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo (Ctrl+Z) affects notebook cell metadata run state #106362

Closed
brettfo opened this issue Sep 9, 2020 · 3 comments
Closed

undo (Ctrl+Z) affects notebook cell metadata run state #106362

brettfo opened this issue Sep 9, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@brettfo
Copy link
Member

brettfo commented Sep 9, 2020

  • VSCode Version: 1.49.0-insider, commit e790b93
  • OS Version: Win10 19041.450 (2004)

Steps to Reproduce:

  1. Install the .NET Interactive Notebook Extension to the latest insiders build.
  2. Open a blank .dib file.
  3. Set the first cell to new System.Random().Next() and execute.
  4. The cell executes as expected.
  5. Ctrl+Z => no visible change.
  6. Ctrl+Z again => cell metadata gets backed off such that it thinks it's running again, but it's not really. No new or different output is produced and the notebook's execute method isn't hit.

Does this issue occur when all extensions are disabled?: N/A

Issue first discovered in dotnet/interactive#748.

@vscodebot
Copy link

vscodebot bot commented Sep 9, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@connor4312
Copy link
Member

@connor4312 connor4312 reopened this Jan 28, 2021
@connor4312 connor4312 added verification-found Issue verification failed and removed verified Verification succeeded labels Jan 28, 2021
@rebornix
Copy link
Member

@connor4312 the fix for now is making sure that the Run button doesn't go back to Stop button, and we didn't do anything with the execution ellapsed time, execution count, etc. The gif you posted above is the expected behavior for now.

Next iteration we will polish the API and execution related stuff will be moved out of the metadata.

@rebornix rebornix removed the verification-found Issue verification failed label Jan 28, 2021
@connor4312 connor4312 added the verified Verification succeeded label Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @brettfo @connor4312 and others