Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codelens with padded with whitespace not showing #106718

Closed
authuir opened this issue Sep 15, 2020 · 8 comments
Closed

Codelens with padded with whitespace not showing #106718

authuir opened this issue Sep 15, 2020 · 8 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug code-lens insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@authuir
Copy link

authuir commented Sep 15, 2020

We found our codelens disappear in specific case in the latest version of VS Code(1.49.0) which won’t repro in previous version.

The root cause is the styling issue which results the third codelens squeezed to another line.

image

If the codelens starts or ends with an space will trigger this issue.

@mjbvz mjbvz assigned jrieken and unassigned mjbvz Sep 15, 2020
@jrieken jrieken added code-lens info-needed Issue requires more information from poster and removed info-needed Issue requires more information from poster labels Sep 15, 2020
@jrieken jrieken changed the title Codelens missing issues in latest VS Code (1.49.0) Codelens with padded with whitespace not showing Sep 15, 2020
@jrieken
Copy link
Member

jrieken commented Sep 15, 2020

If the codelens starts or ends with an space will trigger this issue.

Workaround would then be to remove leading/trailing whitespace, right?

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug electron-9-update labels Sep 15, 2020
@jrieken
Copy link
Member

jrieken commented Sep 15, 2020

This is a regression from updating to electron 9 (which bring a different layout enging). Running with --disable-features=LayoutNG doesn't allow me to reproduce this. fyi @deepak1556 @bpasero

@deepak1556
Copy link
Collaborator

@jrieken would it be possible to distill a minimal repro similar to #88873 (comment) , makes it easier to report upstream.

@jrieken
Copy link
Member

jrieken commented Sep 16, 2020

@authuir Are you the author of that extension? We have scheduled a fix for September and in the meantime the extension could push a change to trim the leading/trailing whitespace

@jrieken jrieken added this to the September 2020 milestone Sep 16, 2020
@jrieken jrieken added the author-verification-requested Issues potentially verifiable by issue author label Sep 16, 2020
@authuir
Copy link
Author

authuir commented Sep 16, 2020

If the codelens starts or ends with an space will trigger this issue.

Workaround would then be to remove leading/trailing whitespace, right?

Yeah, this is what we did

@authuir
Copy link
Author

authuir commented Sep 16, 2020

@authuir Are you the author of that extension? We have scheduled a fix for September and in the meantime the extension could push a change to trim the leading/trailing whitespace

Yeah, I'm the author. Glad to hear that there will be an fix release!

@lifeart
Copy link

lifeart commented Sep 16, 2020

related: #106876

@roblourens roblourens added author-verification-requested Issues potentially verifiable by issue author and removed author-verification-requested Issues potentially verifiable by issue author labels Oct 1, 2020
@github-actions
Copy link

github-actions bot commented Oct 1, 2020

This bug has been fixed in to the latest release of VS Code Insiders!

@authuir, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 2289738 of Insiders (today's or later - you can use Help: About in the command pallete to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@alexr00 alexr00 added the verified Verification succeeded label Oct 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug code-lens insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants
@roblourens @deepak1556 @lifeart @jrieken @authuir @mjbvz @alexr00 and others