Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook diff shows changes the extension doesn't make #107146

Closed
jrieken opened this issue Sep 21, 2020 · 1 comment
Closed

Notebook diff shows changes the extension doesn't make #107146

jrieken opened this issue Sep 21, 2020 · 1 comment
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook

Comments

@jrieken
Copy link
Member

jrieken commented Sep 21, 2020

https://github.com/microsoft/vscode-github-issue-notebooks/blob/edf85a2e9db0d28166526c844e479724434209b6/src/extension/notebookProvider.ts#L271-L276

The pointer above shows what metadata the GH nb extension saves. The diff however, show all kinds of of things, like runState et al.

Screenshot 2020-09-21 at 10 05 03

@jrieken
Copy link
Member Author

jrieken commented Sep 21, 2020

This can likely be adjusted by fiddling with the transient options set but I think the diff should always go with what's stored on disk

@jrieken jrieken self-assigned this Sep 21, 2020
@rebornix rebornix added this to the September 2020 milestone Sep 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook
Projects
None yet
Development

No branches or pull requests

3 participants
@rebornix @jrieken and others