Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore integration between extensions view and GitHub Sponsors #107482

Closed
miguelsolorio opened this issue Sep 25, 2020 · 25 comments · Fixed by #150703
Closed

Explore integration between extensions view and GitHub Sponsors #107482

miguelsolorio opened this issue Sep 25, 2020 · 25 comments · Fixed by #150703
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan ux User experience issues
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Intro

This issue aims to explore what it could look like if we integrated GitHub Sponsors into the extensions view. Currently, extensions are not tied to a single user, so we'd need for a way for an extension to tell us what users they'd like to be added to the "sponsors" list. One idea is having a new entry in the package.json with a list of GitHub usernames that we could link to.

Design

We could remove the redundant information on the installed extensions (ratings + downloads) and add a ❤️ icon that signals to users that an extension can be sponsored by them. When opening the extension, we could have a special GitHub Sponsor button that links to the users being sponsored. One thing we need to consider is having multiple sponsors, do we introduce a new tab that has the list of sponsors? What other information would users want to know about before sponsorin?

image

@miguelsolorio miguelsolorio added ux User experience issues extensions Issues concerning extensions labels Sep 25, 2020
@miguelsolorio miguelsolorio added this to the September 2020 milestone Sep 25, 2020
@miguelsolorio
Copy link
Contributor Author

Here's another alternative where we show a "Sponsor" tag in the header and then what the tab could look like with additional sponsor data from the funding.yml file that is created:

image

@miguelsolorio miguelsolorio changed the title Explore possible integrations between extensions view and GH Explore possible integrations between extensions view and GitHub Sponsors Sep 29, 2020
@miguelsolorio miguelsolorio changed the title Explore possible integrations between extensions view and GitHub Sponsors Explore integration between extensions view and GitHub Sponsors Sep 29, 2020
@RandomFractals
Copy link

please ship the second version with external links for other ways to sponsor.

@Borvik
Copy link

Borvik commented Oct 15, 2020

We could remove the redundant information on the installed extensions (ratings + downloads)

I wouldn't call the ratings/downloads redundant. When someone is searching for an extension and many show up, it is often easier to pick through the list by going straight to the more popular ones. This is usually a first pass I run to help weed out junk extensions (though I understand the extension could just be new) By removing it from the list, you now have an extra click and have to check each and every extension to see this information.

@miguelsolorio
Copy link
Contributor Author

@Borvik I was referring to installed extensions. The ratings and downloads are useful when you are browsing extensions to install but not once you've installed it.

@RandomFractals
Copy link

I did not even catch that in those pics. I agree with @Borvik that it would be helpful to see # of installs and ratings in extensions list. perhaps as another line under ext. name and version in that list view item.

@miguelsolorio
Copy link
Contributor Author

What's helpful about seeing the ratings/downloads for installed extensions?

@RandomFractals
Copy link

as @Borvik mentioned seeing the ratings and number of installs helps devs decide if that is the extension they want to check out, or read the docs, which would be 1 click away now.

@miguelsolorio
Copy link
Contributor Author

I'm trying to understand, why would you want to check out an extension that is already installed? Isn't that something you look into before you install it?

@RandomFractals
Copy link

I would just keep it consistent for both installed and search view display extensions.

@RandomFractals
Copy link

also, does this mean you are finalizing that sponsor buttons UI & will you support other platforms besides github listed in funding.yml?

@Borvik
Copy link

Borvik commented Oct 15, 2020

I didn't realize it was just for installed extensions, I'm ok with it not showing in that list.

Just checked and I'm not seeing it in the list when searching for extensions to install - and I'm not seeing it there - perhaps we need a different issue/request to get rating/installs added to the search list

@miguelsolorio
Copy link
Contributor Author

@RandomFractals this issue is to explore the design of the layout so development hasn't started yet. Since this is specifically about GitHub Sponsors I think using the info from the funding.yml file makes the most sense, so whatever information a repo places in that file is what we will show (like external links).

@Borvik ratings and installs are still part of the extensions view:

@Borvik
Copy link

Borvik commented Oct 15, 2020

my bad - turns out it is a viewport thing - no worries then
image
image

@miguelsolorio
Copy link
Contributor Author

@sandy081 is this a bug? I don't think we ever discussed hiding that from smaller viewports and I think having that info is extremely useful when browsing for extensions.

@RandomFractals
Copy link

I think using the info from the funding.yml file makes the most sense, so whatever information a repo places in that file is what we will show (like external links).

good to hear. I think the installs and ratings display as you have now looks good. Not sure if cramming new sponsor button there makes sense since you plan to add it in the ext. details view.

proceed as mocked up! :) can't wait to see it in the next release or two.

@sandy081
Copy link
Member

@sandy081 is this a bug? I don't think we ever discussed hiding that from smaller viewports and I think having that info is extremely useful when browsing for extensions.

Nopes, this is how it is from the time it is implemented by @joaomoreno 😉

@joaomoreno
Copy link
Member

joaomoreno commented Oct 19, 2020

This is there since day 1. 😆 At some point we gotta make space in order for the ext name to be visible.

@RandomFractals
Copy link

can't you wrap it and show installs and ratings in the next line for smaller viewports like I suggested above?

@isidorn isidorn added this to the December 2021 milestone Nov 18, 2021
@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2022

We have done the initial investigation and we are now working with the Marketplace team on the implementation.
Thus moving to February milestone when we will have more details. Thanks!

@sandy081
Copy link
Member

sandy081 commented May 30, 2022

Supporting sponsoring extensions from VS Code. An extension author can enable sponsoring by providing the sponsor URL in the extension's package.json and VS Code will allow users to sponsor to that extension using following UI. Clicking on sponsor button will take user to the sponsor link provided by the author.

Example:

image

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 30, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 31, 2022
@isidorn
Copy link
Contributor

isidorn commented Jun 3, 2022

Here's the announcement microsoft/vscode-discussions#14
Try it out and let us know what you think in that discussion. Thanks!

@RandomFractals
Copy link

I really like new vscode discussions setup & hope it takes on.

Thank you guys for making it happen & this sponsors feature.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants