-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore integration between extensions view and GitHub Sponsors #107482
Comments
please ship the second version with external links for other ways to sponsor. |
I wouldn't call the ratings/downloads redundant. When someone is searching for an extension and many show up, it is often easier to pick through the list by going straight to the more popular ones. This is usually a first pass I run to help weed out junk extensions (though I understand the extension could just be new) By removing it from the list, you now have an extra click and have to check each and every extension to see this information. |
@Borvik I was referring to installed extensions. The ratings and downloads are useful when you are browsing extensions to install but not once you've installed it. |
I did not even catch that in those pics. I agree with @Borvik that it would be helpful to see # of installs and ratings in extensions list. perhaps as another line under ext. name and version in that list view item. |
What's helpful about seeing the ratings/downloads for installed extensions? |
as @Borvik mentioned seeing the ratings and number of installs helps devs decide if that is the extension they want to check out, or read the docs, which would be 1 click away now. |
I'm trying to understand, why would you want to check out an extension that is already installed? Isn't that something you look into before you install it? |
I would just keep it consistent for both installed and search view display extensions. |
also, does this mean you are finalizing that sponsor buttons UI & will you support other platforms besides github listed in funding.yml? |
I didn't realize it was just for installed extensions, I'm ok with it not showing in that list. Just checked and I'm not seeing it in the list when searching for extensions to install - and I'm not seeing it there - perhaps we need a different issue/request to get rating/installs added to the search list |
@RandomFractals this issue is to explore the design of the layout so development hasn't started yet. Since this is specifically about GitHub Sponsors I think using the info from the @Borvik ratings and installs are still part of the extensions view: |
@sandy081 is this a bug? I don't think we ever discussed hiding that from smaller viewports and I think having that info is extremely useful when browsing for extensions. |
good to hear. I think the installs and ratings display as you have now looks good. Not sure if cramming new sponsor button there makes sense since you plan to add it in the ext. details view. proceed as mocked up! :) can't wait to see it in the next release or two. |
Nopes, this is how it is from the time it is implemented by @joaomoreno 😉 |
This is there since day 1. 😆 At some point we gotta make space in order for the ext name to be visible. |
can't you wrap it and show installs and ratings in the next line for smaller viewports like I suggested above? |
We have done the initial investigation and we are now working with the Marketplace team on the implementation. |
Supporting sponsoring extensions from VS Code. An extension author can enable sponsoring by providing the Example: |
Here's the announcement microsoft/vscode-discussions#14 |
I really like new vscode discussions setup & hope it takes on. Thank you guys for making it happen & this sponsors feature. |
Intro
This issue aims to explore what it could look like if we integrated GitHub Sponsors into the extensions view. Currently, extensions are not tied to a single user, so we'd need for a way for an extension to tell us what users they'd like to be added to the "sponsors" list. One idea is having a new entry in the
package.json
with a list of GitHub usernames that we could link to.Design
We could remove the redundant information on the installed extensions (ratings + downloads) and add a ❤️ icon that signals to users that an extension can be sponsored by them. When opening the extension, we could have a special GitHub Sponsor button that links to the users being sponsored. One thing we need to consider is having multiple sponsors, do we introduce a new tab that has the list of sponsors? What other information would users want to know about before sponsorin?
The text was updated successfully, but these errors were encountered: