Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ms-vscode.js-debug is slow to activate #107680

Closed
jrieken opened this issue Sep 29, 2020 · 2 comments
Closed

ms-vscode.js-debug is slow to activate #107680

jrieken opened this issue Sep 29, 2020 · 2 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Sep 29, 2020

  • get the ms-vscode.js-debug activated
  • check F1 > Startup Performance
  • 🐌 it takes 265ms to load the code for that extension
| ms-vscode.js-debug                         | false | 265       | 11            | 1   
@isidorn isidorn removed their assignment Sep 29, 2020
@connor4312
Copy link
Member

connor4312 commented Sep 29, 2020

Thanks for the issue. js-debug has become a big bundle that activates on quite a few things. We can probably split the "debug adapter" portion of the bundle so that only UI contributions get loaded until a debug session starts.

@connor4312 connor4312 added this to the October 2020 milestone Sep 29, 2020
@connor4312 connor4312 added the polish Cleanup and polish issue label Sep 29, 2020
@connor4312 connor4312 added debt Code quality issues and removed polish Cleanup and polish issue labels Oct 10, 2020
@connor4312
Copy link
Member

In the linked commit I have removed our runtime dependency on TypeScript in favor of Acorn (which we were already using for beautification) which drops the bundle size from 3.6 -> 1.3MB and should significantly improve startup time.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants