Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filename_test.go appears before filename.go in the explorer #107936

Closed
kylrth opened this issue Oct 1, 2020 · 4 comments
Closed

filename_test.go appears before filename.go in the explorer #107936

kylrth opened this issue Oct 1, 2020 · 4 comments
Assignees
@isidorn
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@kylrth
Copy link

kylrth commented Oct 1, 2020 •
edited
Loading

Issue Type: Bug

For items in lexicographic order, an item that prefixes another item should be ranked before that longer item.

In VS Code, alpha_test.go gets displayed before alpha.go:

Screenshot from 2020-10-01 17-25-46

Since we ignore the .go extension when sorting these file names, I think this ordering should be reversed.

VS Code version: Code 1.49.2 (e5e9e69, 2020-09-24T16:26:09.944Z)
OS version: Linux x64 5.4.3-050403-generic snap
Remote OS version: Linux x64 5.4.0-47-generic
@gjsjohnmurray
Copy link
Contributor

Related to #27286 from @bpasero and PR #97272 from @leilapearson

@isidorn
Copy link
Contributor

isidorn commented Oct 2, 2020

Yeah let's close as dup and we can continue the discussion in the PR

@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 2, 2020
@leilapearson
Copy link
Contributor

Also closely related to issue #99955 and PR #104528. These are both closed but they do explain why the code now behaves this way. The code no longer strips off the .go extension before comparing the names.

@leilapearson leilapearson mentioned this issue Oct 2, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@leilapearson @isidorn @kylrth @gjsjohnmurray and others