File Upload still works when "explorer.enableDragAndDrop" is false

[mklechan]

• VSCode Version: 1.49.3
• OS Version: Mac OS

Steps to Reproduce:

1. In settings set "explorer.enableDragAndDrop" to false
2. Drag file from Mac File Explorer to Editor Window
3. Note the file can now be edited and saved to remote or local machine

Does this issue occur when all extensions are disabled?: Yes

[isidorn]

That setting only affects drag and drop from within the explorer.
I understand the setting name might be confusing.
And that it might also disable drag and drop from desktop to vscode.

However for now leaving this open to get more user feedback.

[mklechan]

Hi @isidorn , thanks. Is there a setting to disable file upload and download from the Desktop to VSCode?
If not could you point me to the module that handles this? That way i can understand if i could do this myself.

[isidorn]

No, there is no setting for this.
Here's the code that handles this

vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts

Line 816 in 9eaeb4d

this.dropEnabled = this.configurationService.getValue('explorer.enableDragAndDrop');

I think the change should be simple, I am not sure if it would cause user backlash. So a clean PR is probably welcome.

fyi @bpasero since he originaly introduced the enableDragAndDrop setting

[bpasero]

The original intent of enableDragAndDrop setting was really to prevent accident changes in the explorer when you drag-and-move in the explorer. It has nothing to do with uploading from the desktop. I would not change anything here.

[isidorn]

Makes sense.
Then the only thing we could do is improve the setting description.

[isidorn]

As discussed I have only pushed a clarification of the setting.
No further changes are planned thus closing this.

[mklechan]

@isidorn I was able to stop file uploads by setting MAX_FILE_UPLOAD_SIZE to 0
with enableDragAndDrop set to false I can stop uploads to both the Editor and the Explorer.

But I can still download files from VSCode to my Mac by dragging and dropping. Is there a better place in the code to stop this?
I was looking at:

vscode/src/vs/platform/download/common/downloadService.ts

Line 22 in 776541c

async download(resource: URI, target: URI, cancellationToken: CancellationToken = CancellationToken.None): Promise<void> {

But that doesnt seem to work

Thanks

[isidorn]

@mklechan we do not have plans to change this at the moment, so even if you create a PR, we would probably not merge this in.
As for the code pointer, here is where the drop is handled

vscode/src/vs/workbench/contrib/files/browser/views/explorerViewer.ts

Line 986 in 7536644

this.compressedDropTargetDisposable.dispose();