Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the latest Emmet #110697

Closed
Mister-Hope opened this issue Nov 16, 2020 · 4 comments
Closed

Migrate to the latest Emmet #110697

Mister-Hope opened this issue Nov 16, 2020 · 4 comments
Assignees
@rzhao271
Labels
emmet Emmet related issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2021

Comments

@Mister-Hope
Copy link

Mister-Hope commented Nov 16, 2020 •
edited
Loading

VSCode is still using emmet 2.0, but emmet has a few bug fixes and update in the past year. I am running into these bugs.

I just tested on the newest emmt and the issue is gone.

So I would like to request updating vscode emmet version to the newest 2.2.1
@vscodebot
Copy link

vscodebot bot commented Nov 16, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Mister-Hope Mister-Hope reopened this Nov 16, 2020
@chrmarti chrmarti added the emmet Emmet related issues label Nov 16, 2020
@chrmarti chrmarti assigned rzhao271 and unassigned chrmarti Nov 16, 2020
@rzhao271 rzhao271 changed the title update emmet version Migrate to the latest Emmet Nov 16, 2020
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Nov 16, 2020
@rzhao271 rzhao271 added this to the November 2020 milestone Nov 16, 2020
@rzhao271
Copy link
Contributor

Yep, see https://github.com/microsoft/vscode/issues?q=is%3Aissue+label%3Aemmet-revamp+is%3Aopen+ for a list of issues that should be fixed during the migration or shortly after

@rzhao271 rzhao271 mentioned this issue Nov 16, 2020
Closed
65 tasks
@kieferrm kieferrm mentioned this issue Dec 14, 2020
Closed
73 tasks
@rzhao271
Copy link
Contributor

rzhao271 commented Jan 6, 2021

I migrated to the latest Emmet in dc5a3da, but I'll keep this issue open because that dependency is not from the actual emmetio/emmet branch, but from a branch of my own that contains an unmerged PR.

@rzhao271 rzhao271 modified the milestones: January 2021, February 2021 Jan 22, 2021
@rzhao271 rzhao271 added on-release-notes Issue/pull request mentioned in release notes feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Feb 1, 2021
@rzhao271 rzhao271 modified the milestones: February 2021, January 2021 Feb 1, 2021
@rzhao271 rzhao271 removed the on-release-notes Issue/pull request mentioned in release notes label Feb 1, 2021
@rzhao271 rzhao271 modified the milestones: January 2021, February 2021 Feb 1, 2021
@rzhao271
Copy link
Contributor

Verify by code review

@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Feb 12, 2021
@roblourens roblourens added the verified Verification succeeded label Feb 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
emmet Emmet related issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
5 participants
@roblourens @rzhao271 @chrmarti @Mister-Hope and others