Make PowerShell 7+ the default shell if it's available

[TylerLeonhardt]

Scenario

The specific scenario I want to solve for is this:

• JS/Java/Python developer on Windows wants to use the latest PowerShell because improved shell experience
• They install PowerShell from the Microsoft Store because it's the easiest way for them to get it and auto-update
• They expect that the PowerShell they installed from the Store replaces Windows PowerShell as the default shell used in VS Code

NOTE: part of this assumption the user has is because PS7 already shows up as the default in Windows Terminal (if PS7 is installed)

This would be a great way for customers adoption of the latest version of PowerShell rather than using Windows PowerShell which hasn't been updated in years.

Today

Today the user can "choose their default shell" in the drop down of terminals but this does not work for PowerShell installed via the Store because the install location is different... So today, the user can only, configure their shell on windows to be "terminal.integrated.shell.windows": "pwsh" to set the shell to any PowerShell 7.

Much like Windows Terminal, VS Code could discover which PowerShell is available and use that as the default so that users can easily transition.

Design ideas

In the PowerShell extension, we wrote up this very exhaustive class that could "discover" powershell on any platform:

https://github.com/PowerShell/vscode-powershell/blob/master/src/platform.ts#L67

This includes scenarios like PowerShell installed via Store, PowerShell installed via .NET Global Tool, install via MSI... etc.

I originally showed this code to WT folks so they may have adapted it for them.

I think the "terminal.integrated.shell.windows" should still be honored if it is set for backcompat purposes.

[eamodio]

@meganrogge I would hope we could prioritize this higher, as the vscode experience when installing PowerShell from the Microsoft Store is basically broken -- we won't show that option at all.

[TylerLeonhardt]

Bolded that bit. That to me seems like a bug and the making it the default is more of a feature ask... guess this could have been two separate issues but the going above and beyond by making PS7 the default will be a way better experience for everyone.

[lramos15]

#115113

[TylerLeonhardt]

#115113 has been fixed