Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please suppress duplicate threads requests #110927

Closed
polinasok opened this issue Nov 19, 2020 · 3 comments
Closed

Please suppress duplicate threads requests #110927

polinasok opened this issue Nov 19, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster

Comments

@polinasok
Copy link

Threads requests can be expensive (e.g. microsoft/debug-adapter-protocol#159), so it would be great if the editor avoided sending duplicate ones when the program is stopped and the state is not changing. Please see issue golang/vscode-go#940 for details on when dups can occur. It would be great if requests issued on stopped events and not just on thread events were checked for duplication. Even if we avoid pulling duplicate information from the debug backend in the debug adapter, we would still need to send the duplicate responses back, which could be a performance hit. Getting to the root of the duplication on the editor end would be most efficient.

@weinand weinand assigned isidorn and unassigned weinand Nov 19, 2020
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug labels Nov 19, 2020
@weinand
Copy link
Contributor

weinand commented Nov 19, 2020

@polinasok agreed, VS Code should not request threads unnecessarily.

@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2020

Agreed.

@polinasok can you please create a reproducible steps using Mock debug or js debugging so I can reproduce this on my machine.
If that is not convenient we also accept PRs that would potentially fix this on the VS Code side.
You can put a breakpoint here and check when the threads is called duplicated.

Thanks

@isidorn isidorn added the info-needed Issue requires more information from poster label Feb 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants
@weinand @isidorn @polinasok and others