-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress: cannot cancel #111578
Comments
We do not allow to cancel when there is only one operation. This is as designed since file system providers currently do not support canceling. So on the Bulk Edit Service we can only cancel by not doing the remaining operations. Though download might be a special case operation (I have to check if it goes through the Bulk Edit Service). Assigning to November for initial investigation. fyi @jrieken |
I think we can still offer cancellation, even if the file system provider API does not allow it all the way down. We can cancel on a per-file basis at least for the "Download" and "Upload" operations. Move/Delete possibly not because they are implemented over the generic file system APIs in most cases. |
Not something I want to change in endgame, thus moving to debt week for discussions. |
Bulk edit does support cancellation, for file edits it is just a matter of passing it down to the working copy service and so on. If cancelation is then actually doing something is up to the receiver of that token |
Is there any change this is going to be implemented ? |
For anyone who stumbles here from Google: you can force the cancellation of a download by reloading the window (Develop: Reload Window in command pallet). |
Testing #111250
It does not seem possible to cancel the operations from the explorer, e.g. download (tried download from a remote Codespace).
The text was updated successfully, but these errors were encountered: