Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress: cannot cancel #111578

Open
bpasero opened this issue Dec 1, 2020 · 6 comments
Open

Progress: cannot cancel #111578

bpasero opened this issue Dec 1, 2020 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Dec 1, 2020

Testing #111250

It does not seem possible to cancel the operations from the explorer, e.g. download (tried download from a remote Codespace).

@isidorn
Copy link
Contributor

isidorn commented Dec 1, 2020

We do not allow to cancel when there is only one operation. This is as designed since file system providers currently do not support canceling. So on the Bulk Edit Service we can only cancel by not doing the remaining operations.

Though download might be a special case operation (I have to check if it goes through the Bulk Edit Service). Assigning to November for initial investigation.

fyi @jrieken

@isidorn isidorn added this to the November 2020 milestone Dec 1, 2020
@isidorn isidorn added the file-explorer Explorer widget issues label Dec 1, 2020
@bpasero
Copy link
Member Author

bpasero commented Dec 1, 2020

I think we can still offer cancellation, even if the file system provider API does not allow it all the way down. We can cancel on a per-file basis at least for the "Download" and "Upload" operations. Move/Delete possibly not because they are implemented over the generic file system APIs in most cases.

@isidorn
Copy link
Contributor

isidorn commented Dec 3, 2020

Not something I want to change in endgame, thus moving to debt week for discussions.
The issue is that BulkEditService currently does not distuinguish between different operations when reporting progress and would be nice if it stayed that way.
Also assigning to @jrieken for thoughts

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Dec 3, 2020
@jrieken jrieken removed their assignment Dec 11, 2020
@jrieken
Copy link
Member

jrieken commented Dec 11, 2020

The issue is that BulkEditService currently does not distuinguish between different operations when reporting progress and would be nice if it stayed that way.

Bulk edit does support cancellation, for file edits it is just a matter of passing it down to the working copy service and so on. If cancelation is then actually doing something is up to the receiver of that token

@onurtore
Copy link

onurtore commented Nov 7, 2023

Is there any change this is going to be implemented ?

@muonmax
Copy link

muonmax commented Nov 29, 2023

For anyone who stumbles here from Google: you can force the cancellation of a download by reloading the window (Develop: Reload Window in command pallet).

@lramos15 lramos15 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

7 participants