Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window that contains the passed file should have focus on restore #111612

Closed
isidorn opened this issue Dec 1, 2020 · 7 comments
Closed

Window that contains the passed file should have focus on restore #111612

isidorn opened this issue Dec 1, 2020 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-window Window management
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 1, 2020

Testing #111420

  1. window.restoreWindow: preserve
  2. Have a couple of windows open, for example vscode-smoketest-express repo and some other
  3. Exit vscode
  4. Open vscode from the command line such that some file from the vscode-smoketest-express repo is passed as command line
  5. The correct VS Code windows are restored, however the one that should be focused and in front should be the one containg the file just passed - thus the vscode-smoketest-express repo. However focus is on the window which had last focus before exiting.
@isidorn
Copy link
Contributor Author

isidorn commented Dec 1, 2020

Same if I pass a code-workspace file, that window should be in front and focused

@bpasero bpasero added the workbench-window Window management label Dec 1, 2020
@bpasero bpasero added this to the November 2020 milestone Dec 1, 2020
@bpasero
Copy link
Member

bpasero commented Dec 2, 2020

I pushed c447320 which will ensure that the window the files are open in get's focus. However, seeing #111620 and #111605, this may not be the window that is the parent of that file.

@bpasero bpasero closed this as completed Dec 2, 2020
@bpasero
Copy link
Member

bpasero commented Dec 2, 2020

@isidorn maybe you could verify this (out of sources is fine too), I am not entirely sure I got your second comment right.

@isidorn
Copy link
Contributor Author

isidorn commented Dec 2, 2020

My second comment is: if I pass a code-workspace file to open a brand new workspace that window shuold be focused.

Sure I can verify this, adding label bug so I do not miss this

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Dec 2, 2020
@bpasero
Copy link
Member

bpasero commented Dec 2, 2020

if I pass a code-workspace file to open a brand new workspace that window shuold be focused.

Hm interesting, while this seems to work for folders, it does not seem to work with workspace files. Is that what you saw? Passing a new folder correctly focusses that new folder even when other windows restore, but not when you pass a workspace file from the command line?

@isidorn
Copy link
Contributor Author

isidorn commented Dec 2, 2020

Correct. That is what I saw.

@bpasero
Copy link
Member

bpasero commented Dec 2, 2020

Ok will look into that separately.

@isidorn isidorn added the verified Verification succeeded label Dec 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-window Window management
Projects
None yet
Development

No branches or pull requests

2 participants