Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a warning when an externalConsole attribute used in Launch #11209

Closed
sandy081 opened this issue Aug 30, 2016 · 7 comments
Closed

Provide a warning when an externalConsole attribute used in Launch #11209

sandy081 opened this issue Aug 30, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Aug 30, 2016

Testing #11091

Steps to Reproduce:

Since externalConsole attribute is deprecated, it would make sense to show a warning in the launches when this attribute is used.

@sandy081 sandy081 added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 30, 2016
@weinand weinand assigned isidorn and unassigned weinand Aug 30, 2016
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2016

August to investigate

@isidorn isidorn added this to the August 2016 milestone Aug 30, 2016
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2016

@isidorn isidorn closed this as completed Aug 30, 2016
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2016
@isidorn isidorn reopened this Aug 30, 2016
@isidorn
Copy link
Contributor

isidorn commented Aug 30, 2016

Actually that is not a good fix, since we still want to show the message that the attribute is deprecated.
@aeschli we want to always show a custom warning message for a field in our json schema. I figured we can use a pattern that always fails and use the errorMessage there. But not sure if there is some nicer way to achieve this?

@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2016

I would do the 'pattern' and 'custom error' message trick. JSON schema doesn't have a way to disallow a specific property. You can enforce that only the specified properties are allowed, but the error message will be generic.

@isidorn
Copy link
Contributor

isidorn commented Aug 31, 2016

Work on our side is done, for this to fully work we are waiting for #11305

@sandy081
Copy link
Member Author

sandy081 commented Sep 1, 2016

@isidorn It seems the warning is appearing on the value instead of the attribute. It looks like as if the value is not supported. But in this case attribute itself is not valid. So does it makes sense to show squiggle on attribute or complete attribute-value?

screen shot 2016-09-01 at 11 23 56

@isidorn
Copy link
Contributor

isidorn commented Sep 1, 2016

@sandy081 It would be nicer to show the warning on the attribute, but this is not currently supported by @aeschli. So we are doing this as a workaround

@sandy081 sandy081 added the verified Verification succeeded label Sep 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants