-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook diff: renderer support #112486
Comments
The first step is loading the static renderers in the diff view. It will come with following changes:
The next step would be supporting multiple outputs in a single cell, which will require absolutely positioning every output and cache the output position with prefix sum. |
In order to share the webview infra we had in the native notebook editor, we want to make
Currently I hacked around everything and have builtin renderers in webview |
By making the webview module generic (I mean literally, `), we share the same code for rendering outputs in the webview. The missing part is loading kernel preload scripts but we can look into them at the end. Now we have output webview rendering on both sides By making the webview module generic (literally, |
Current notebook diff editor only compares and presents the changes in text diff editors, we may also want to support renderers in the diff view just like what we did in the native notebook editor.
The text was updated successfully, but these errors were encountered: