-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer to open a workspace from empty explorer #112730
Comments
This makes sense. However the reason against it is to not make this any more complicated for new users who have no clue what a workspace is. @sandy081 do you have a code pointer on how to use the new UI component? |
Yeah agree it is a bit more advanced and requires the user to have a |
You can use following action item to render an action with dropdown menu
To render a button you can use
|
Looking at the latest videos done by @burkeholland I am worried that this might just confuse new users additionally - what I already mentioned. Maybe I bring this up in the UX meeting next week. @misolori |
Moving to next milestone to do it start of February to get user feedback |
Looks cool! |
In other places where I show this similar button (extensions), I also show the main action in the dropdown (from UX feedback I received). So, to be consistent, shall the dropdown also include main |
Looks good to me, agree that the primary action must be the first in the dropdown. |
Agree. Also it is a bit funky that some of them have a |
They should all use a "..." at the end of the label if additional user input is required to perform the action which I think is true for all. |
Yeah I know that pattern, I am just saying that for me personally in a clean welcome Explorer an |
In order to have this we would need support from the welcome views since the explorer is using the welcome view infrastructure. Anyways moving to On-Deck, since we will not have time for this this milestone. |
FYI @eamodio |
Oh man, we're growing this. Calling @jrieken for comments. |
I really like the idea of allowing extensions to add a button with multiple choices because that could mean the overall number of visible buttons is reduced 👍 |
Should we just allow to reference a submenu? |
Current semantics are that if the link is by itself on a line, it becomes a button. We could extend this to convert a line that is exclusively links to render as a dropdown button, with the first being the main title.
Not sure what referencing a submenu would look like. |
The empty explorer currently looks like this:
I see how we want to save space and not show a "Open Workspace" button below the "Open Folder" button, but I think we could maybe leverage @sandy081 work and show a button with a dropdown?
The way this could work is:
If we go down this path I would think the wording should also be tweaked ("You have not yet opened a folder or workspace").
The UI component I am referring to is this:
The text was updated successfully, but these errors were encountered: