Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight the line for current search result #11318

Closed
sandy081 opened this issue Aug 31, 2016 · 2 comments
Closed

Highlight the line for current search result #11318

sandy081 opened this issue Aug 31, 2016 · 2 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Milestone
September 2016

Comments

@sandy081
Copy link
Member

Find widget highlights the line for current find match. Allow the same behavior of Search.
@sandy081 sandy081 added feature-request Request for new features or functionality search Search widget and operation issues labels Aug 31, 2016
@sandy081 sandy081 added this to the September 2016 milestone Aug 31, 2016
@sandy081 sandy081 mentioned this issue Aug 31, 2016
Closed
@sandy081
Copy link
Member Author

sandy081 commented Sep 8, 2016

Implemented by 24743e8

@sandy081 sandy081 closed this as completed Sep 8, 2016
@sandy081 sandy081 added the verification-needed Verification of issue is requested label Sep 8, 2016
@sandy081
Copy link
Member Author

sandy081 commented Sep 8, 2016

Verification:

Note: Line highlight used should be same as in Find / Go to line / Outline / Problems view

  • Single click on the result -> Line highlight is shown.
  • Type Space on the result -> Line highlight is shown.
  • Toggle Search view -> Line highlight is also toggled.
  • Click inside editor -> Line highlight is removed.
  • Double click on the result -> No line highlight is shown.
  • When Search view is hidden, no line highlights from Search view are shown.
  • When results are cleared, line highlight is removed
  • When new search is performed, line highlight is removed

@sandy081 sandy081 self-assigned this Sep 9, 2016
@kieferrm kieferrm mentioned this issue Sep 13, 2016
Closed
@chrmarti chrmarti mentioned this issue Sep 26, 2016
Closed
1 task
@sandy081 sandy081 removed the verification-needed Verification of issue is requested label Sep 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
1 participant
@sandy081