Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth API specs two labels and uses both #114685

Closed
jrieken opened this issue Jan 21, 2021 · 3 comments
Closed

Auth API specs two labels and uses both #114685

jrieken opened this issue Jan 21, 2021 · 3 comments
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jan 21, 2021

The current API allows to define a label in package.json and when registering. I believe the former is enough but I am sure that in case both are needed one should win

"authentication": [
	{
		"id": "autho",
		"label": "[Autho(PGJ)]"
	}
],
 vscode.authentication.registerAuthenticationProvider('autho', '[Autho]', new Autho());

Screenshot 2021-01-21 at 09 17 48

Screenshot 2021-01-21 at 09 17 56

@jrieken
Copy link
Member Author

jrieken commented Jan 21, 2021

required for #88309

@RMacfarlane
Copy link
Contributor

Augh I forgot about this problem.

My current thinking is we should get rid of the package.json registration. We needed that for exposing a providers property on authentication that was synchronous, but I'm not sure that is actually needed. I think it does have value for extension authors to learn what provider ids to use, but I think the use case of checking it at runtime is rare.

@jrieken jrieken added this to the February 2021 milestone Feb 23, 2021
@jrieken jrieken added the api label Feb 23, 2021
@RMacfarlane
Copy link
Contributor

The label specified in registerAuthenticationProvider is now used everywhere

a5a8392

@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 25, 2021
@connor4312 connor4312 added the verified Verification succeeded label Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants