Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Allow tabs to wrap to multi-line #114827

Closed
3 tasks done
bpasero opened this issue Jan 23, 2021 · 0 comments
Closed
3 tasks done

Test: Allow tabs to wrap to multi-line #114827

bpasero opened this issue Jan 23, 2021 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jan 23, 2021

Refs: #70413

Complexity: 4

Create Issue


A new setting workbench.editor.wrapTabs enables tabs to wrap instead of showing a scrollbar. This requires workbench.editor.showTabs: true.

Verify Basics:

  • make sure you have configured workbench.editor.tabSizing: fit (this will make the last tab fill the entire row for a more homogeneous look when tabs wrap)
  • wrapping works as you would expect when space is too limited to show all tabs (easy to test having 2 editor groups side by side)
  • you do not encounter screen cheese or a broken editor (the editor height should always match the height of the container minus the height of all tabs)
  • the editor toolbar always shows bottom right and is fully visible (above tabs are not blocked by its space)
  • if the space for the editor or editor toolbar becomes too small, wrapping turns off automatically and turns on again when the size get's larger
  • opening and closing tabs updates the tab well accordingly (e.g. tabs start to wrap when new editors open and space is not sufficient)
  • you can still drag and drop tabs around even when they wrap
  • you can still pin a tab and it shows pinned in the beginning of the tabs
  • when tabs wrap, the tab.border color is not only applied to the right of each tab but also below to separate tabs from each other

Verify Settings

  • enable workbench.editor.tabSizing: shrink and do a quick smoke test that wrapping works as before (now you will notice that tabs do not automatically fill the entire row anymore when wrapping)
  • enable or disable breadcrumbs and verify they work as expected
@bpasero bpasero added this to the January 2021 milestone Jan 23, 2021
@lszomoru lszomoru removed their assignment Jan 26, 2021
@eamodio eamodio removed their assignment Jan 26, 2021
@rebornix rebornix removed their assignment Jan 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants