Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editor goes stale #115042

Closed
jrieken opened this issue Jan 26, 2021 · 3 comments
Closed

Diff editor goes stale #115042

jrieken opened this issue Jan 26, 2021 · 3 comments
Assignees
@rebornix
Labels
*caused-by-extension Issue identified to be caused by an extension

Comments

@jrieken
Copy link
Member

jrieken commented Jan 26, 2021

Testing #114969

  • added the plotly.txt-based notebook, file as untracked
  • open diff editor, everything is new
  • commit the file
  • close editors
  • reopen notebook, delete a cell
  • open diff
  • 🐛 diff shows old/stale information

Screenshot 2021-01-26 at 14 38 17
@rebornix
Copy link
Member

The Jupyter extension doesn't resolve the right content for the git resource.

@rebornix rebornix mentioned this issue Jan 27, 2021
Closed
@rebornix rebornix added the *caused-by-extension Issue identified to be caused by an extension label Jan 27, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Jan 28, 2021

I don't believe this is the extension's fault. It looks like we're not queried for the cells from the git-resource. We're only queried for the result on disk?

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rebornix @jrieken @rchiodo and others