Changing output ids cause false diffs

[jrieken]

Testing #114969

• use the plotly.txt-notebook, tracked, not changes
• delete a cell, save
• diff editor shows the deleted cells but also red/green for other outputs
• text-diff of the output shows that it is output ids (this might be an issue with the jupyter extension)

[rebornix]

The jupyter extension may want to make it transient, which we don't currently support yet. cc @DonJayamanne

[DonJayamanne]

@rebornix Apologies for the delay in looking into this.
The property outputId is something VS Code is in control of. We don't add this & don't even have access to this property.
I think VSCode should not display this in the diff viewer at all, I think its used internally by VS Code (when rendering output).

See here for spec of output (there is no outputId)

	export interface CellDisplayOutput {
		outputKind: CellOutputKind.Rich;
		/**
		 * { mime_type: value }
		 *
		 * Example:
		 * ```json
		 * {
		 *   "outputKind": vscode.CellOutputKind.Rich,
		 *   "data": {
		 *      "text/html": [
		 *          "<h1>Hello</h1>"
		 *       ],
		 *      "text/plain": [
		 *        "<IPython.lib.display.IFrame at 0x11dee3e80>"
		 *      ]
		 *   }
		 * }
		 */
		data: { [key: string]: any; };

		readonly metadata?: NotebookCellOutputMetadata;
	}

[rebornix]

This issue should be gone now as we move to the new API and only compare outputItems now.