Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook icon problems #115094

Closed
Tyriar opened this issue Jan 26, 2021 · 3 comments
Closed

Notebook icon problems #115094

Tyriar opened this issue Jan 26, 2021 · 3 comments
Assignees

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2021

Testing #114969

Maybe this belongs to the Jupyter extension?

  • Export as and open jupyter variable view looks really bad on standard dpi
  • Not enough contrast on the green icons, we shouldn't be using color at all yet blue, green and red are used

image

  • Run cell and below and run cells above do not show up initially, you need to focus another cell to get it to show up

image

  • Trusted is red initially and then it turns green when opening - this should be green from the beginning to reduce visual noise
@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jan 26, 2021

Yea, this is from the Jupyter/Python extension. Moved to microsoft/vscode-jupyter#4508.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 26, 2021

@misolori @rebornix this one may be in core?

Run cell and below and run cells above do not show up initially, you need to focus another cell to get it to show up

@miguelsolorio
Copy link
Contributor

That's also from the extension, but this is expected behavior as it requires a selection to run. We have similar actions in the GH Issues notebook for splitting cells that only shows up when you're in a code cell.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants