Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a terminal toggle in the status bar #115657

Closed
miguelsolorio opened this issue Feb 3, 2021 · 5 comments
Closed

Introduce a terminal toggle in the status bar #115657

miguelsolorio opened this issue Feb 3, 2021 · 5 comments
Assignees
Labels
*extension-candidate Issue identified as good extension implementation terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Refs #115641

This idea is to introduce a terminal toggle in the status bar to increase visibility and discoverability. Once the user starts a terminal session, the terminal item should update the count to reflect this.

Screen.Recording.2021-02-02.at.8.49.01.PM.mov

I'll bring this up in our ux sync to discuss with the team

@miguelsolorio miguelsolorio added ux User experience issues terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach labels Feb 3, 2021
@usernamehw
Copy link
Contributor

It would be great to:

  • Have different icon for each terminal (3 terminal sessions - 3 icons)
  • Have different icons for different types of terminal (cmd vs bash vs powershell vs other types)
  • Have a busy indicator that something is running in the terminal

This feature will be helpful for all users, not only new users.

@Tyriar
Copy link
Member

Tyriar commented Feb 3, 2021

Have different icon for each terminal (3 terminal sessions - 3 icons)

This is essentially my extension: https://marketplace.visualstudio.com/items?itemName=Tyriar.terminal-tabs, I don't think we should do this as it will be covered by terminal tabs eventually (#10546) , the main purpose of this feature would be helping with discoverability of the terminal.

Have different icons for different types of terminal (cmd vs bash vs powershell vs other types)

Again this would belong in an extension imo.

Have a busy indicator that something is running in the terminal

I mentioned this yesterday, it's a little tricky defining what is "running" though. For example often it is when some process is running but that can't be relied upon because maybe the process isn't busy (eg. running bash inside bash, running git log and leaving it). Maybe the most useful thing here is when output happens in a backgrounded terminal the spinner goes for a second or something 🤔. I'm not sure if there's an issue tracking this yet but it would make sense to tackle again after tabs.

@usernamehw
Copy link
Contributor

@Tyriar Is there an extension api: If you can type / send text to terminal or not?

@miguelsolorio miguelsolorio added this to the Backlog milestone Feb 22, 2021
@krish-r
Copy link

krish-r commented Oct 1, 2021

+1

I believe following are the options available right now to open/toggle the terminal (on Windows). And, I don't think there is any one-click option to access the terminal (other than the first option).

  • Ctrl + `
  • View -> Toggle
  • Command Palette -> View: Toggle Terminal
  • Terminal -> New Terminal (Only applicable for the first time)
  • Problems view toggle -> select Terminal tab

And, I find the last option to be easy compared to the rest (may be I'm just used to it).

So, IMHO it will be really helpful to have a dedicated Terminal toggle similar (& next) to Problems view toggle. image
(Even if it doesn't display the terminal count).

@Tyriar Tyriar added the *extension-candidate Issue identified as good extension implementation label Oct 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*extension-candidate Issue identified as good extension implementation terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

6 participants
@Tyriar @usernamehw @meganrogge @miguelsolorio @krish-r and others