-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ code highlighting fails for large files #11597
Comments
@ArashPartow Are you using any extensions for C++ or just VS Code out of the box? |
@ramya-rao-a I'm using the C/C++ for Visual Studio Code extension. http://pasteboard.co/3A56demY.png I have tried with the extension being active and disabled and still get the same results. Though I did notice that when the extension is disabled the whitening seems to happen a couple of thousand lines later than when it is enabled. |
@alexandrudima The textmate tokenizer seems to return tokens, but we don't show them. |
@aeschli I have improved vscode-textmate's
I will spend some time to isolate the constructs that lead to rules being pushed without being popped by the grammar. Once I do so, where can I file the bug (where do these grammars come from?) |
The grammars are from https://github.com/atom/language-c. You can see this by checking the OSSREADME in the corresponding extension. |
Thank you, I asked because I saw two entries. Is the textmate/c.tmbundle still used? |
We still have /extensions/cpp/syntaxes/Platform.tmLanguage in there from the original https://github.com/textmate/c.tmbundle as it is included by other languages (Objective-C) |
Update: I've recently updated to version 1.6.1 and am still seeing the above described problem. |
Update: I've recently updated to version 1.7.0 and am still seeing the above described problem. |
Update: I've recently updated to version 1.7.1 and am still seeing the above described problem. |
Update: I've recently updated to version 1.7.2 and am still seeing the above described problem. |
Update: I've recently updated to version 1.8.0 and am still seeing the above described problem. |
Update: I've recently updated to version 1.8.1 and am still seeing the above described problem. |
@alexandrudima @joaomoreno Just tried out the fix using version 1.9.0 and it's all working great. Thank-you! |
Upgraded vscode installation, the C++ code highlighting now starts to fail at around line 4000
The following file was used: https://raw.githubusercontent.com/ArashPartow/exprtk/master/exprtk.hpp
The following screenshot demonstrates the problem: http://pasteboard.co/hJ6RUAZtU.png
The following is from the start of the file: http://pasteboard.co/hJ7kaH2X7.png
The following is from the end of the file: http://pasteboard.co/hJ7Gp4nLR.png
Tried other files with the same results:
The text was updated successfully, but these errors were encountered: