Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow tabs to expand when using editor.wrapTabs #116145

Closed
jjspace opened this issue Feb 8, 2021 · 5 comments
Closed

Don't allow tabs to expand when using editor.wrapTabs #116145

jjspace opened this issue Feb 8, 2021 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@jjspace
Copy link

jjspace commented Feb 8, 2021

When tabs wrap to a new line the they start to stretch and expand to fill available space on the new row. This is conflicting behavior with how they behave if there are not enough tabs to fill the first row. In this case they all keep the max width they should take up and no more. I would expect all tabs to act this way regardless of which row they are on, not expand. I find the expanding looks wrong, the close X is too far away from the file name. Same problem when combined with the new editor.decorations.badges, they can be very "far" from the filename.

Please at least add an option to not allow the tabs to expand.

  • VSCode Version: 1.53.0

Steps to Reproduce:

  1. Enable editor.wrapTabs
  2. Open enough tabs that they wrap to a new line
@vscodebot
Copy link

vscodebot bot commented Feb 8, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jjspace
Copy link
Author

jjspace commented Feb 8, 2021

I'm not super familiar with the VSCode code but playing around with the inspector it seems removing this style rule almost achieves what I'm looking for.

.monaco-workbench .part.editor>.content .editor-group-container>.title>.tabs-and-actions-container.wrapping .tabs-container>.tab.sizing-fit {
    flex-grow:1;
}

However it does seem this has the side-effect of allow a row that's not the "last" one have empty space at the end of it which I assume is why this rule was created in the first place. I think a good solution might be to prevent the flex-grow on only tabs in the last row. However I'm not sure how easy that would be within the structure of this app.

@yume-chan
Copy link
Contributor

Duplicate of #113801

1 similar comment
@meganrogge
Copy link
Contributor

Duplicate of #113801

@meganrogge meganrogge marked this as a duplicate of #113801 Feb 8, 2021
@meganrogge meganrogge added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 8, 2021
@jjspace
Copy link
Author

jjspace commented Feb 8, 2021

Haha race to the finish @yume-chan and @meganrogge! Thanks guys, I tried looking first but couldn't find that issue for some reason. 👍

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants