Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff: support "compaction heuristic" #11657

Closed
alexkrolick opened this issue Sep 7, 2016 · 3 comments
Closed

Diff: support "compaction heuristic" #11657

alexkrolick opened this issue Sep 7, 2016 · 3 comments
Assignees
@alexdima
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality on-testplan
Milestone
July 2017

Comments

@alexkrolick
Copy link

alexkrolick commented Sep 7, 2016 •
edited
Loading

Git 2.9.0 introduced a "compaction heuristic" option that uses blank lines as a "strong hint" in computing diff block boundaries. It would be nice to get use a similar heuristic in the VS Code diff viewer. (If it is using the git diff util behind-the-scenes, this would already work).

https://github.com/blog/2188-git-2-9-has-been-released#beautiful-diffs

  • VSCode Version: 1.5.0
  • OS Version: Mac OS
  • Git Version: 2.9.0+
@ramya-rao-a ramya-rao-a added the git GIT issues label Sep 8, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Sep 8, 2016 •
edited
Loading

Code doesn't use git for diffing behind the scenes. But it's a valid request for the diff algorithm.

@joaomoreno joaomoreno reopened this Sep 8, 2016
@joaomoreno joaomoreno changed the title Enable git diff --compactionHeuristic or similar whitespace detection Diff: support "compaction heuristic" Sep 8, 2016
@joaomoreno joaomoreno assigned alexdima and unassigned joaomoreno Sep 8, 2016
@joaomoreno joaomoreno added feature-request Request for new features or functionality diff-editor Diff editor issues and removed git GIT issues labels Sep 8, 2016
@alexdima alexdima mentioned this issue Sep 12, 2016
Closed
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@alexdima alexdima removed their assignment Mar 2, 2017
@alexdima
Copy link
Member

alexdima commented Jul 4, 2017 •
edited
Loading

I think I just implemented this in c8df698 (for #30087)

@alexdima alexdima modified the milestones: July 2017, Backlog Jul 4, 2017
@alexdima alexdima closed this as completed Jul 4, 2017
@alexdima alexdima self-assigned this Jul 4, 2017
@joaomoreno
Copy link
Member

damn son

@kieferrm kieferrm mentioned this issue Jul 7, 2017
Closed
39 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
diff-editor Diff editor issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
5 participants
@joaomoreno @alexkrolick @weinand @alexdima @ramya-rao-a