Splitting terminal ignores "terminal.integrated.splitCwd": "inherited" and instead starts in workspace root

[chrisdakin]

• VS Code Version: 1.53.2
  

• OS Version: 11.2.1
  

Steps to Reproduce:

1. Make sure terminal.integrated.splitCwd is set to inherited
2. Change directory
3. Split terminal (hotkey or by clicking split terminal)

Expected: New terminal starts in previous terminal's directory
Actual: New terminal starts in workspace directory

Screen.Recording.2021-02-19.at.2.06.55.PM.mov

Does this issue occur when all extensions are disabled?: Yes

Additional notes: This happens 100% of the time for me. It first started happening when I updated both to the newest version of VS Code (January) and to Big Sur (updated both at the same time). This happens when the default integrated terminal is bash and when it is zsh.

[Tyriar]

This was disabled on Big Sur only as a workaround for #105446

[Tyriar]

I see it was reverted upstream, we will eventually enable it again when it's definitely fixed in Electron @deepak1556 ?

[deepak1556]

@Tyriar the libuv fix is not reverted in vscode, I haven't responded to the last comment in #105446, tl:dr; I have evaluated the failing scenarios in the libuv case and added workarounds for them in internal builds.

[sguillia]

@Tyriar This regression just made it through 1.61.0 and also reproduces on Linux

1.60.2

Expected and actual: New terminal starts in previous terminal's directory

1.61.0

Expected: New terminal starts in previous terminal's directory
Actual: New terminal starts in workspace directory

---

I've been used to the previous behavior for years, would it be possible to roll back?

Working version

Version: 1.60.2
Commit: 7f6ab5485bbc008386c4386d08766667e155244e
Date: 2021-09-22T12:01:43.795Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 4.15.0-142-generic

Non-working version

Version: 1.61.0
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:11:02.929Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 4.15.0-142-generic

[Tyriar]

@meganrogge could the event change in 6a7445b have caused that breakage on Linux?

[ebeloded]

With every VSCode I hope this issue is fixed. In the latest release - it still isn't. I'm experiencing this on Mac.

[Tyriar]

Splitting is working fine on the latest macOS now. Please open a new issue with specific repro steps if you see this issue again.