Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate open with logic #117206

Closed
bpasero opened this issue Feb 22, 2021 · 0 comments
Closed

Duplicate open with logic #117206

bpasero opened this issue Feb 22, 2021 · 0 comments
Assignees
@lramos15 @mjbvz
Labels
custom-editors Custom editor API (webview based editors) debt Code quality issues insiders-released Patch has been released in VS Code Insiders perf-bloat
Milestone
March 2021

Comments

@bpasero
Copy link
Member

bpasero commented Feb 22, 2021

While working on #116856 I noticed that the entire logic of "Open With..." seems to be duplicate between editorOpenWith.ts and customEditor.ts:

vscode/src/vs/workbench/contrib/customEditor/browser/customEditors.ts

Line 148 in 4aa4d1f

private showOpenWithPrompt(

and

vscode/src/vs/workbench/services/editor/common/editorOpenWith.ts

Line 34 in 572bc18

export async function openEditorWith(

After #116856 lands, imho the one in customEditor.ts needs to go away.
@bpasero bpasero added perf-bloat custom-editors Custom editor API (webview based editors) labels Feb 22, 2021
@mjbvz mjbvz added the debt Code quality issues label Feb 26, 2021
@mjbvz mjbvz closed this as completed in 20ec5b8 Mar 2, 2021
@bpasero bpasero added this to the March 2021 milestone Mar 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

@mjbvz mjbvz

Labels
custom-editors Custom editor API (webview based editors) debt Code quality issues insiders-released Patch has been released in VS Code Insiders perf-bloat
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
4 participants
@bpasero @lramos15 @mjbvz and others